Skip to content

feat: add support of the ai variant key for images #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fangoling wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add support of the ai variant key for images #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/theia-cloud/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ A Helm chart for Theia Cloud
| keycloak.enable | bool | `false` | Whether keycloak authentication shall be used |
| keycloak.realm | string | `"TheiaCloud"` | The Keycloak Realm. Only has to be specified when enable: true |
| landingPage | object | (see details below) | Values related to the landing page |
| landingPage.additionalApps | string | `nil` | The page may show these additional apps in a drop down. This is a map. The key maps to the app definition name. The value contains the label shown in the UI and may optionally include `image` or `Image` to override the logo name/path forwarded to the landing page config. Example: different-app-definition: label: "Different App Definition" image: "different-app-definition" |
| landingPage.additionalApps | string | `nil` | The page may show these additional apps in a drop down. This is a map. The key maps to the app definition name. The value contains the label shown in the UI and may optionally include `image`/`Image`, `visible`, `buildSystems`, and `aiVariant` fields forwarded to the landing page config. Example: different-app-definition: label: "Different App Definition" image: "different-app-definition" aiVariant: "different-app-definition-ai" |
| landingPage.appDefinition | string | `"theia-cloud-demo"` | the app id to launch |
| landingPage.disableInfo | bool | `false` | Should showing info title and text below the launch button be disabled true hides the info title and text false shows the info title and text |
| landingPage.enabled | bool | `true` | Whether the landing page shall be enabled |
Expand Down
3 changes: 3 additions & 0 deletions charts/theia-cloud/templates/landing-page-config-map.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ data:
{
serviceAuthToken: {{ $key | quote}},
appName: {{ $val.label | quote }},
{{- if $val.aiVariant }}
aiVariant: {{ tpl ($val.aiVariant | toString) $root | quote }},
{{- end }}
{{- if and (hasKey $val "visible") (ne (toString (get $val "visible")) "true") }}
visible: {{ get $val "visible" }},
{{- end }}
Expand Down
3 changes: 2 additions & 1 deletion charts/theia-cloud/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,13 +120,14 @@ landingPage:
# -- The page may show these additional apps in a drop down. This is a map.
# The key maps to the app definition name
# The value contains the label shown in the UI and may optionally contain
# an image override that is forwarded to the landing page config.
# image, visible, buildSystems, and aiVariant fields forwarded to the landing page config.
#
# Example:
# different-app-definition:
# label: "Different App Definition"
# image: "different-app-definition"
# visible: false
# aiVariant: "different-app-definition-ai"
# further-app-definition:
# label: "Further App Definition"
additionalApps:
Expand Down
Loading