Skip to content

Feat/add-bazel-url-and-restructure-helm-values#21

Open
KevinGruber2001 wants to merge 2 commits into
mainfrom
feat/add-bazel-url
Open

Feat/add-bazel-url-and-restructure-helm-values#21
KevinGruber2001 wants to merge 2 commits into
mainfrom
feat/add-bazel-url

Conversation

@KevinGruber2001
Copy link
Copy Markdown

@KevinGruber2001 KevinGruber2001 commented May 22, 2026

  • Add Bazel URL as an argument
  • Restructure Helm values

Summary by CodeRabbit

  • Chores
    • Updated chart version to 1.4.0-next.7
    • Restructured build cache and dependency cache configuration settings in deployment values

Review Change Stack

@KevinGruber2001 KevinGruber2001 self-assigned this May 22, 2026
@KevinGruber2001 KevinGruber2001 added the enhancement New feature or request label May 22, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

📝 Walkthrough

Walkthrough

The Helm chart theia-cloud restructures operator caching configuration from flat keys into nested blocks (operator.buildCache and operator.dependencyCache), updates the operator template to use the new paths, and bumps the chart version to 1.4.0-next.7.

Changes

Helm operator cache configuration restructuring

Layer / File(s) Summary
Cache values schema restructure
charts/theia-cloud/values.yaml
Build cache settings now nest under operator.buildCache with enabled, separate gradleUrl and bazelUrl, and enablePush; dependency cache settings now nest under operator.dependencyCache with enabled and url.
Operator template caching arguments
charts/theia-cloud/templates/operator.yaml
Container args section updated to conditionally emit --buildCacheUrl, --bazelBuildCacheUrl, --enableBuildCachePush, and --dependencyCacheUrl flags using the new nested value paths.
Chart version update
charts/theia-cloud/Chart.yaml
Helm chart version bumped from 1.4.0-next.6 to 1.4.0-next.7.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • EduIDE/EduIDE-Helm#13: Chart version bumps in theia-cloud between different 1.4.0-next.* releases.
  • EduIDE/EduIDE-Helm#6: Introduced the original flat cache configuration keys that are being restructured into nested blocks in this PR.

Suggested reviewers

  • lukaskratzel
  • CodeByNikolas

Poem

🐰 A flatter schema once did lay,
But nesting brings a brighter day!
Build and deps now nestled tight,
Chart bumped high—the config's right! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: adding Bazel URL support and restructuring Helm values into nested configuration blocks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/add-bazel-url

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@charts/theia-cloud/templates/operator.yaml`:
- Around line 100-120: Add a one-release compatibility fallback for legacy cache
keys so upgrades don't silently disable caching: in the operator.yaml template,
introduce local Helm template variables (e.g., using {{- $bc :=
.Values.operator.buildCache }} / {{- $dc := .Values.operator.dependencyCache }}
or use coalesce/default/hasKey) that prefer the new keys
(.Values.operator.buildCache.enabled, .Values.operator.buildCache.gradleUrl,
.Values.operator.buildCache.bazelUrl, .Values.operator.buildCache.enablePush,
.Values.operator.dependencyCache.enabled, .Values.operator.dependencyCache.url)
but fall back to the legacy key names if present; then use those local vars when
rendering the flags (instead of directly referencing
.Values.operator.buildCache.* and .Values.operator.dependencyCache.*) so
existing values.yaml files remain compatible for one release.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8f3f7987-c6b1-491f-94ea-4039e3b1bf93

📥 Commits

Reviewing files that changed from the base of the PR and between 5c3955c and 82a32ac.

📒 Files selected for processing (3)
  • charts/theia-cloud/Chart.yaml
  • charts/theia-cloud/templates/operator.yaml
  • charts/theia-cloud/values.yaml

Comment thread charts/theia-cloud/templates/operator.yaml
Copy link
Copy Markdown
Member

@Fangoling Fangoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants