Feat/add-bazel-url-and-restructure-helm-values#21
Conversation
📝 WalkthroughWalkthroughThe Helm chart ChangesHelm operator cache configuration restructuring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/theia-cloud/templates/operator.yaml`:
- Around line 100-120: Add a one-release compatibility fallback for legacy cache
keys so upgrades don't silently disable caching: in the operator.yaml template,
introduce local Helm template variables (e.g., using {{- $bc :=
.Values.operator.buildCache }} / {{- $dc := .Values.operator.dependencyCache }}
or use coalesce/default/hasKey) that prefer the new keys
(.Values.operator.buildCache.enabled, .Values.operator.buildCache.gradleUrl,
.Values.operator.buildCache.bazelUrl, .Values.operator.buildCache.enablePush,
.Values.operator.dependencyCache.enabled, .Values.operator.dependencyCache.url)
but fall back to the legacy key names if present; then use those local vars when
rendering the flags (instead of directly referencing
.Values.operator.buildCache.* and .Values.operator.dependencyCache.*) so
existing values.yaml files remain compatible for one release.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8f3f7987-c6b1-491f-94ea-4039e3b1bf93
📒 Files selected for processing (3)
charts/theia-cloud/Chart.yamlcharts/theia-cloud/templates/operator.yamlcharts/theia-cloud/values.yaml
Summary by CodeRabbit