Skip to content

bugfix: no session start if not logged in#8

Open
KevinGruber2001 wants to merge 7 commits into
mainfrom
bug/no-session-start-if-logged-out
Open

bugfix: no session start if not logged in#8
KevinGruber2001 wants to merge 7 commits into
mainfrom
bug/no-session-start-if-logged-out

Conversation

@KevinGruber2001
Copy link
Copy Markdown
Contributor

@KevinGruber2001 KevinGruber2001 commented Mar 10, 2026

Currently the redirect url only includes origin and pathname, but window.location.search, which includes the path parameters like artemisToken and appDefinition.. is missing.

This PR adds the window.location.search to the redirectURL

Summary by CodeRabbit

  • Bug Fixes

    • Authentication now preserves full URL query parameters on redirect so users retain search/filter state after login.
  • Chores

    • Simplified and updated CI build workflow and image configuration; removed build-time cache/platform flags and related workflow outputs.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 10, 2026

📝 Walkthrough

Walkthrough

Updated Keycloak redirectUri in src/App.tsx to preserve the full URL including query string. Adjusted .github/workflows/docker-build.yml to change the referenced reusable workflow, remove cache/tag handling, and update the image-name and build inputs.

Changes

Cohort / File(s) Summary
Keycloak Redirect URI Configuration
src/App.tsx
Compute redirectUri as window.location.origin + window.location.pathname + window.location.search and use it for Keycloak init/login calls, preserving query parameters.
CI Workflow / Docker Build
.github/workflows/docker-build.yml
Replaced reusable workflow reference branch with @main, changed image-name from ghcr.io/EduIDE/eduidec-landing-page to eduide/eduide/landing-page, removed cache_tag output propagation and removed build inputs/flags related to build-amd64, build-arm64, cache-from, and cache-to; minor whitespace edits.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through routes both short and long,
Sniffed every query, hummed a tiny song,
The redirect now carries each little part,
From origin to search — a whole-map heart,
Hop on, auth flow, steady and strong! 🥕✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions 'no session start if not logged in', but the actual changes preserve query parameters in the redirect URL and update Docker workflow references. The title does not accurately reflect these changes. Update the title to reflect the actual primary changes, such as 'Fix: preserve query parameters in Keycloak redirect URL' or 'Update Docker workflow and preserve query parameters'.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bug/no-session-start-if-logged-out

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/docker-build.yml:
- Line 50: Replace the reusable workflow reference that currently uses the
moving target
"EduIDE/.github/.github/workflows/build-and-push-docker-image.yml@main" with a
pinned commit SHA; locate the workflow step that uses that exact string and
update the ref (the part after the @) to the full commit SHA of the intended
commit in the EduIDE repo so the action imports a fixed, reproducible version.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8d372492-dd71-4fa9-ae5b-7c7ed82b6db8

📥 Commits

Reviewing files that changed from the base of the PR and between e05c553 and cdeba71.

📒 Files selected for processing (1)
  • .github/workflows/docker-build.yml

Comment thread .github/workflows/docker-build.yml Outdated
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/docker-build.yml:
- Line 47: The image-name value is wrong: remove the redundant namespace and the
ghcr.io prefix (the reusable workflow adds it automatically) by changing the
image-name key value from "eduide/eduide/landing-page" to "eduide/landing-page";
also update README.md to replace the outdated
"ghcr.io/EduIDE/eduidec-landing-page" reference with
"ghcr.io/eduide/landing-page" (or just "eduide/landing-page" where workflow docs
assume the registry prefix) so docs and the image-name field (image-name) are
consistent.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3f790200-467a-4d07-aad5-b60bcb1a529f

📥 Commits

Reviewing files that changed from the base of the PR and between cdeba71 and ebee003.

📒 Files selected for processing (1)
  • .github/workflows/docker-build.yml

Comment thread .github/workflows/docker-build.yml
build-and-push-landing-page:
needs: determine-tag
uses: EduIDE/.github/.github/workflows/build-and-push-docker-image.yml@feature/arc-runner-support
uses: ls1intum/.github/.github/workflows/build-and-push-docker-image.yml@main
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we do not move this to the eduide org?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we did not have the build-and-push-docker-image workflow in our org, so a non existing workflow was used. We can allso migrate that workflow in our org

@Mtze
Copy link
Copy Markdown
Member

Mtze commented Apr 30, 2026

What is the state on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Session does not start if called from artemis and the user has to log in first

3 participants