bugfix: no session start if not logged in#8
Conversation
📝 WalkthroughWalkthroughUpdated Keycloak redirectUri in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/docker-build.yml:
- Line 50: Replace the reusable workflow reference that currently uses the
moving target
"EduIDE/.github/.github/workflows/build-and-push-docker-image.yml@main" with a
pinned commit SHA; locate the workflow step that uses that exact string and
update the ref (the part after the @) to the full commit SHA of the intended
commit in the EduIDE repo so the action imports a fixed, reproducible version.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8d372492-dd71-4fa9-ae5b-7c7ed82b6db8
📒 Files selected for processing (1)
.github/workflows/docker-build.yml
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/docker-build.yml:
- Line 47: The image-name value is wrong: remove the redundant namespace and the
ghcr.io prefix (the reusable workflow adds it automatically) by changing the
image-name key value from "eduide/eduide/landing-page" to "eduide/landing-page";
also update README.md to replace the outdated
"ghcr.io/EduIDE/eduidec-landing-page" reference with
"ghcr.io/eduide/landing-page" (or just "eduide/landing-page" where workflow docs
assume the registry prefix) so docs and the image-name field (image-name) are
consistent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3f790200-467a-4d07-aad5-b60bcb1a529f
📒 Files selected for processing (1)
.github/workflows/docker-build.yml
| build-and-push-landing-page: | ||
| needs: determine-tag | ||
| uses: EduIDE/.github/.github/workflows/build-and-push-docker-image.yml@feature/arc-runner-support | ||
| uses: ls1intum/.github/.github/workflows/build-and-push-docker-image.yml@main |
There was a problem hiding this comment.
Is there a reason why we do not move this to the eduide org?
There was a problem hiding this comment.
we did not have the build-and-push-docker-image workflow in our org, so a non existing workflow was used. We can allso migrate that workflow in our org
|
What is the state on this PR? |
Currently the redirect url only includes origin and pathname, but window.location.search, which includes the path parameters like artemisToken and appDefinition.. is missing.
This PR adds the window.location.search to the redirectURL
Summary by CodeRabbit
Bug Fixes
Chores