Skip to content

add tls for liveness and readyness #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinGruber2001 merged 1 commit into from
Feb 7, 2026
Merged

add tls for liveness and readyness #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions chart/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ spec:
httpGet:
path: /ping
port: http
{{- if .Values.tls.enabled }}
scheme: HTTPS
{{- end }}
initialDelaySeconds: 10
periodSeconds: 10
timeoutSeconds: 5
Expand All @@ -97,6 +100,9 @@ spec:
httpGet:
path: /health
port: http
{{- if .Values.tls.enabled }}
scheme: HTTPS
{{- end }}
initialDelaySeconds: 5
periodSeconds: 5
timeoutSeconds: 3
Expand Down
11 changes: 10 additions & 1 deletion src/internal/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"fmt"
"net/http"
"time"

"github.com/gin-gonic/gin"
"github.com/kevingruber/gradle-cache/internal/config"
Expand Down Expand Up @@ -159,7 +160,15 @@ func (s *Server) Run(ctx context.Context) error {
select {
case <-ctx.Done():
s.logger.Info().Msg("shutting down server")
return srv.Shutdown(context.Background())

shutdownCtx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()

if err := srv.Shutdown(shutdownCtx); err != nil {
return fmt.Errorf("server shutdown failed %w", err)

}
return nil
case err := <-errCh:
return err
}
Expand Down