Skip to content

Don’t create a table when it’s not needed #5840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thewilkybarkid wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don’t create a table when it’s not needed #5840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tall-ideas-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@effect/cluster": patch
---

Don’t create a table when it’s not needed
32 changes: 18 additions & 14 deletions packages/cluster/src/SqlRunnerStorage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,21 +140,25 @@ export const make = Effect.fnUntraced(function*(options: {
)
`,
mysql: () =>
sql`
CREATE TABLE IF NOT EXISTS ${locksTableSql} (
shard_id VARCHAR(50) PRIMARY KEY,
address VARCHAR(255) NOT NULL,
acquired_at DATETIME NOT NULL
)
`,
disableAdvisoryLocks ?
sql`
CREATE TABLE IF NOT EXISTS ${locksTableSql} (
shard_id VARCHAR(50) PRIMARY KEY,
address VARCHAR(255) NOT NULL,
acquired_at DATETIME NOT NULL
)
` :
Effect.void,
pg: () =>
sql`
CREATE TABLE IF NOT EXISTS ${locksTableSql} (
shard_id VARCHAR(50) PRIMARY KEY,
address VARCHAR(255) NOT NULL,
acquired_at TIMESTAMP NOT NULL
)
`,
disableAdvisoryLocks ?
sql`
CREATE TABLE IF NOT EXISTS ${locksTableSql} (
shard_id VARCHAR(50) PRIMARY KEY,
address VARCHAR(255) NOT NULL,
acquired_at TIMESTAMP NOT NULL
)
` :
Effect.void,
orElse: () =>
// sqlite
sql`
Expand Down