fix(Effect): add Refinement narrowing support for retry while option#6210
Open
lihan3238 wants to merge 1 commit intoEffect-TS:mainfrom
Open
fix(Effect): add Refinement narrowing support for retry while option#6210lihan3238 wants to merge 1 commit intoEffect-TS:mainfrom
lihan3238 wants to merge 1 commit intoEffect-TS:mainfrom
Conversation
When the `while` option receives a Refinement<E, E2>, the output error type is now narrowed to Exclude<E, E2>, matching the symmetry of the existing `until` Refinement narrowing. Closes Effect-TS#6122
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
Refinement-based type narrowing for thewhileoption inEffect.retry, symmetric with the existinguntilnarrowing.When
whilereceives aRefinement<E, E2>, the output error type is now narrowed toExclude<E, E2>— the errors that causewhileto returnfalseand pass through.Closes #6122
Test plan
while+ Refinementuntilnarrowing is unchangedE)