Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/k8s-null-last-transition-time.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@effect/cluster": patch
---

Allow Kubernetes pod condition `lastTransitionTime` values to be null.
6 changes: 3 additions & 3 deletions packages/cluster/src/K8sHttpClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ export class PodStatus extends Schema.Class<PodStatus>("@effect/cluster/K8sHttpC
conditions: Schema.Array(Schema.Struct({
type: Schema.String,
status: Schema.String,
lastTransitionTime: Schema.String
lastTransitionTime: Schema.NullOr(Schema.String)
})),
podIP: Schema.String,
hostIP: Schema.String
Expand All @@ -208,8 +208,8 @@ export class Pod extends Schema.Class<Pod>("@effect/cluster/K8sHttpClient/Pod")(
}

get isReadyOrInitializing(): boolean {
let initializedAt: string | undefined
let readyAt: string | undefined
let initializedAt: string | null | undefined
let readyAt: string | null | undefined
for (let i = 0; i < this.status.conditions.length; i++) {
const condition = this.status.conditions[i]
switch (condition.type) {
Expand Down
34 changes: 34 additions & 0 deletions packages/cluster/test/K8sHttpClient.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import { assert, describe, it } from "@effect/vitest"
import { Effect, Schema } from "effect"
import * as K8sHttpClient from "../src/K8sHttpClient.js"

describe("K8sHttpClient", () => {
describe("Pod", () => {
it.effect("decodes null lastTransitionTime values", () =>
Effect.sync(() => {
const pod = Schema.decodeSync(K8sHttpClient.Pod)({
status: {
phase: "Running",
conditions: [
{
type: "Initialized",
status: "True",
lastTransitionTime: null
},
{
type: "Ready",
status: "False",
lastTransitionTime: null
}
],
podIP: "10.0.0.1",
hostIP: "10.0.0.2"
}
})

assert.strictEqual(pod.status.conditions[0]?.lastTransitionTime, null)
assert.isFalse(pod.isReady)
assert.isTrue(pod.isReadyOrInitializing)
}))
})
})
Loading