feat(sql-node-sqlite): add native node:sqlite support#6220
Open
hxx0215 wants to merge 1 commit intoEffect-TS:next-minorfrom
Open
feat(sql-node-sqlite): add native node:sqlite support#6220hxx0215 wants to merge 1 commit intoEffect-TS:next-minorfrom
hxx0215 wants to merge 1 commit intoEffect-TS:next-minorfrom
Conversation
🦋 Changeset detectedLatest commit: c49c9ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hxx0215
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
This PR introduces the
@effect/sql-sqlite-node-sqlitepackage to provide first-class support for the nativenode:sqlitemodule (the built-inDatabaseSyncAPI available in Node.js 22.x+ and Deno 2.x+).By leveraging the native
node:sqlitemodule, this new adapter offers:Known Limitation & Discussion
During testing, I noticed that the SQLite engine bundled within Node.js natively does not currently seem to be compiled with the
SQLITE_ENABLE_UPDATE_DELETE_LIMIToption (unlikebetter-sqlite3which compiles it manually).So SqlPersistedQueue cannot work with this package properly. Could the upstream team please advise on how to handle this gracefully?
Related