Fix integer overflow in JPEG 2000 encode output buffer sizing#163
Open
osklu002 wants to merge 1 commit into
Open
Fix integer overflow in JPEG 2000 encode output buffer sizing#163osklu002 wants to merge 1 commit into
osklu002 wants to merge 1 commit into
Conversation
img_size was accumulated in a uint, which overflows for images where width * height * precision * components exceeds 2^32 bits (e.g. RGB 8-bit images larger than ~179 megapixels). The wrapped value produced an output buffer roughly one tenth of the required size, causing opj_encode to fail with "Unable to JPEG 2000 encode image". Accumulate in ulong instead and clamp the requested buffer length to the maximum array length.
Author
|
This adresses #131 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
img_size was accumulated in a uint, which overflows for images where width * height * precision * components exceeds 2^32 bits (e.g. RGB 8-bit images larger than ~179 megapixels). The wrapped value produced an output buffer roughly one tenth of the required size, causing opj_encode to fail with "Unable to JPEG 2000 encode image".
Accumulate in ulong instead and clamp the requested buffer length to the maximum array length.