Fix/UI stablility (#468)

* Fix double click on view manifest button
check the manifest hash on upload ballots

* updated version number

Author: SteveMaier-IRT

src/electionguard-ui/ElectionGuard.UI/ElectionGuard.UI.csproj

@@ -18,8 +18,8 @@
 		<ApplicationIdGuid>c0679a79-bc22-46ad-9c49-93de983e3fa2</ApplicationIdGuid>
 
 		<!-- Versions -->
-		<ApplicationDisplayVersion>1.91.16</ApplicationDisplayVersion>
-		<ApplicationVersion>14</ApplicationVersion>
+		<ApplicationDisplayVersion>1.91.17</ApplicationDisplayVersion>
+		<ApplicationVersion>17</ApplicationVersion>
 
 		<SupportedOSPlatformVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'maccatalyst'">15.3</SupportedOSPlatformVersion>
 		<SupportedOSPlatformVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'windows'">10.0.19041.0</SupportedOSPlatformVersion>

src/electionguard-ui/ElectionGuard.UI/Platforms/Windows/Package.appxmanifest

@@ -4,7 +4,7 @@
   xmlns:mp="http://schemas.microsoft.com/appx/2014/phone/manifest"
   xmlns:rescap="http://schemas.microsoft.com/appx/manifest/foundation/windows10/restrictedcapabilities" IgnorableNamespaces="uap rescap">
 
-  <Identity Name="ElectionGuard.Admin" Publisher="CN=Microsoft" Version="1.91.16.0" />
+  <Identity Name="ElectionGuard.Admin" Publisher="CN=Microsoft" Version="1.91.17.0" />
 
   <mp:PhoneIdentity PhoneProductId="F7E69798-9268-43DC-A51E-3A95FA4992AD" PhonePublisherId="00000000-0000-0000-0000-000000000000"/>
 

src/electionguard-ui/ElectionGuard.UI/Resx/AppResources.Designer.cs

@@ -648,4 +648,7 @@
   <data name="NetworkIssueText" xml:space="preserve">
     <value>Hubo un problema con la red que causó un problema con lo que estabas haciendo.  ¡Vuelve a iniciar sesión cuando se haya restablecido la conexión de red!</value>
   </data>
+  <data name="WrongElectionText" xml:space="preserve">
+    <value>Drive contiene papeletas para una elección diferente.!</value>
+  </data>
 </root>

src/electionguard-ui/ElectionGuard.UI/Resx/AppResources.es.resx

@@ -645,4 +645,7 @@
   <data name="NetworkIssueText" xml:space="preserve">
     <value>There was an issue with the network that caused an issue with what you were doing.  Please log back in when the network connection has been restored</value>
   </data>
+  <data name="WrongElectionText" xml:space="preserve">
+    <value>Drive contains ballots for a different election.</value>
+  </data>
 </root>

src/electionguard-ui/ElectionGuard.UI/Resx/AppResources.resx

@@ -12,6 +12,7 @@ public partial class BallotUploadViewModel : BaseViewModel
 {
     public const string ElectionIdParam = "ElectionId";
     private const string _artifactSubFolder = "artifacts";
+    private const string _contextFilename = "context.json";
     private const string _ballotSubFolder = "encrypted_ballots";
     private readonly string[] _deviceFolderNames = { "devices", "encryption_devices" };
 
@@ -403,6 +404,17 @@ await Shell.Current.CurrentPage.Dispatcher.DispatchAsync(async () =>
                         return;
                     }
 
+                    if (await ValidateElectionId(drive, _manifestHash!) == false)
+                    {
+                        ErrorMessage = AppResources.WrongElectionText;
+                        _importing = false;
+                        return;
+                    }
+                    else
+                    {
+                        ErrorMessage = string.Empty;
+                    }
+
                     // find device file
                     var devices = Directory.GetFiles(devicePath);
                     foreach (var device in devices)
@@ -466,6 +478,18 @@ private string GetDevicesPath(DriveInfo drive)
         return string.Empty;
     }
 
+    private async Task<bool> ValidateElectionId(DriveInfo drive, ElementModQ electionHash)
+    {
+        var filePath = Path.Combine(drive.Name, _artifactSubFolder, _contextFilename);
+        if (File.Exists(filePath))
+        {
+            var contextData = await ReadFileAsync(filePath);
+            var context = new CiphertextElectionContext(contextData);
+            return context.ManifestHash.Equals(electionHash);
+        }
+        return false;
+    }
+
     public override async Task OnAppearing()
     {
         await base.OnAppearing();

src/electionguard-ui/ElectionGuard.UI/ViewModels/BallotUploadViewModel.cs

@@ -48,6 +48,10 @@ public ElectionViewModel(
     [NotifyCanExecuteChangedFor(nameof(AddBallotsCommand))]
     private Election? _currentElection;
 
+    [ObservableProperty]
+    [NotifyCanExecuteChangedFor(nameof(ViewCommand))]
+    private bool _isViewing;
+
     [ObservableProperty]
     private string _electionId;
 
@@ -315,14 +319,21 @@ private async Task MarkCurrentElectionAsExported()
         Step1Complete = true;
     }
 
-    [RelayCommand]
+    [RelayCommand(CanExecute = nameof(CanView))]
     private async Task View()
     {
+        IsViewing = true;
         var vm = (ManifestViewModel)Ioc.Default.GetService(typeof(ManifestViewModel));
         vm.Manifest = new Manifest(Manifest.ToJson());
 
-        await NavigationService.GoToModal(typeof(ManifestViewModel));
+        await NavigationService.GoToModal(typeof(ManifestViewModel));
+        IsViewing = false;
     }
+
+    private bool CanView()
+    {
+        return !IsViewing;
+    }
 
     partial void OnManifestRecordChanged(ManifestRecord value)
     {