Fix order of the checklist checks to make sure that the UI updates properly. (#464)

Author: SteveMaier-IRT

src/electionguard-ui/ElectionGuard.UI/ElectionGuard.UI.csproj

@@ -18,7 +18,7 @@
 		<ApplicationIdGuid>c0679a79-bc22-46ad-9c49-93de983e3fa2</ApplicationIdGuid>
 
 		<!-- Versions -->
-		<ApplicationDisplayVersion>1.91</ApplicationDisplayVersion>
+		<ApplicationDisplayVersion>1.91.14</ApplicationDisplayVersion>
 		<ApplicationVersion>14</ApplicationVersion>
 
 		<SupportedOSPlatformVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'maccatalyst'">15.3</SupportedOSPlatformVersion>

src/electionguard-ui/ElectionGuard.UI/Models/TallyCeremonyChecklist.cs

@@ -56,15 +56,15 @@ public TallyCeremonyChecklist(
         _challengesResponded = challengesResponded;
         QuorumReached = _guardiansJoined >= _quorum;
         State = tally.State;
-        TallyComplete = State == TallyState.Complete;
+        SubtaliesCombined = State >= TallyState.PendingGuardianDecryptShares;
+        AllDecryptionSharesComputed = SubtaliesCombined &&
+            (State > TallyState.PendingGuardianDecryptShares ||
+            (State == TallyState.PendingGuardianDecryptShares && _sharesComputed >= _quorum));
         ChallengeCreated = AllDecryptionSharesComputed && State >= TallyState.PendingGuardianRespondChallenge;
-        AllChallengesResponded = ChallengeCreated && 
+        AllChallengesResponded = ChallengeCreated &&
             (State > TallyState.PendingGuardianRespondChallenge ||
             (State == TallyState.PendingGuardianRespondChallenge && _challengesResponded == _quorum));
-        AllDecryptionSharesComputed = SubtaliesCombined && 
-            (State > TallyState.PendingGuardianDecryptShares ||
-            (State == TallyState.PendingGuardianDecryptShares && _sharesComputed >= _quorum));
-        SubtaliesCombined = State >= TallyState.PendingGuardianDecryptShares;
+        TallyComplete = State == TallyState.Complete;
         TallyStarted = State >= TallyState.TallyStarted;
         IsAbandoned = State == TallyState.Abandoned;
     }