Skip to content

Commit 78c486c

Browse files
committed
move make_count_request impl
1 parent 2aec6ae commit 78c486c

1 file changed

Lines changed: 13 additions & 4 deletions

File tree

src/lpdb_python/session.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -201,10 +201,7 @@ def make_count_request(
201201
:raises ValueError: if an invalid `lpdb_datatype` is supplied
202202
:raises LpdbError: if something went wrong with the request
203203
"""
204-
response = self.make_request(
205-
lpdb_datatype, wiki, conditions=conditions, query="count::objectname"
206-
)
207-
return response[0]["count_objectname"]
204+
pass
208205

209206
@abstractmethod
210207
def get_team_template(
@@ -367,6 +364,18 @@ def make_request(
367364
)
368365
return LpdbSession.__handle_response(lpdb_response)
369366

367+
@override
368+
def make_count_request(
369+
self,
370+
lpdb_datatype: LpdbDataType,
371+
wiki: str,
372+
conditions: Optional[str] = None,
373+
) -> int:
374+
response = self.make_request(
375+
lpdb_datatype, wiki, conditions=conditions, query="count::objectname"
376+
)
377+
return response[0]["count_objectname"]
378+
370379
@override
371380
def get_team_template(
372381
self, wiki: str, template: str, date: Optional[date] = None

0 commit comments

Comments
 (0)