validate datatype names

Author: ElectricalBoy

src/lpdb/async_session/async_session.py

@@ -1,7 +1,7 @@
 from datetime import date
 from http import HTTPStatus
 from types import TracebackType
-from typing import Any, Literal, Optional
+from typing import Any, Literal, Optional, override
 
 import aiohttp
 
@@ -78,6 +78,8 @@ async def make_request(
         order: Optional[list[tuple[str, Literal["asc", "desc"]]]] = None,
         groupby: Optional[list[tuple[str, Literal["asc", "desc"]]]] = None,
     ) -> list[dict[str, Any]]:
+        if not AbstractLpdbSession._validate_datatype_name(lpdb_datatype):
+            raise ValueError(f'Invalid LPDB data type: "{lpdb_datatype}"')
         async with self.__session.get(
             lpdb_datatype,
             headers=self._get_header(),

src/lpdb/session.py

@@ -1,7 +1,7 @@
 from abc import abstractmethod, ABC
 from datetime import date
 from http import HTTPStatus
-from typing import Any, Final, Literal, NotRequired, Optional, Required, TypedDict
+from typing import Any, Final, Literal, NotRequired, Optional, override, Required, TypedDict, TypeGuard
 import re
 import warnings
 
@@ -11,6 +11,8 @@
 
 __all__ = ["LpdbError", "LpdbWarning", "LpdbSession"]
 
+type LpdbDataType = Literal["broadcasters", "company", "datapoint", "externalmedialink", "match", "placement", "player", "series", "squadplayer", "standingsentry", "standingstable", "team", "tournament", "transfer"]
+
 
 class LpdbResponse(TypedDict):
     """
@@ -54,6 +56,23 @@ class AbstractLpdbSession(ABC):
 
     BASE_URL: Final[str] = "https://api.liquipedia.net/api/v3/"
 
+    __DATA_TYPES: Final[set[str]] = {
+        "broadcasters",
+        "company",
+        "datapoint",
+        "externalmedialink",
+        "match",
+        "placement",
+        "player",
+        "series",
+        "squadplayer",
+        "standingsentry",
+        "standingstable",
+        "team",
+        "tournament",
+        "transfer",
+    }
+
     __api_key: str
 
     def __init__(self, api_key: str):
@@ -66,6 +85,10 @@ def _get_header(self) -> dict[str, str]:
             "accept-encoding": "gzip",
         }
 
+    @staticmethod
+    def _validate_datatype_name(lpdb_datatype: str) -> TypeGuard[LpdbDataType]:
+        return lpdb_datatype in AbstractLpdbSession.__DATA_TYPES
+
     @staticmethod
     @abstractmethod
     def get_wikis() -> set[str]:
@@ -179,7 +202,7 @@ def _parse_params(
         if isinstance(wiki, str):
             parameters["wiki"] = wiki
         elif isinstance(wiki, list):
-            parameters["wiki"] = "|".join(wiki)
+            parameters["wiki"] = ", ".join(wiki)
         else:
             raise TypeError()
         parameters["limit"] = min(limit, 1000)
@@ -239,7 +262,7 @@ def __handle_response(response: requests.Response) -> list[dict[str, Any]]:
 
     def make_request(
         self,
-        lpdb_datatype,
+        lpdb_datatype: str,
         wiki: str | list[str],
         limit: int = 20,
         offset: int = 0,
@@ -248,6 +271,8 @@ def make_request(
         order: Optional[list[tuple[str, Literal["asc", "desc"]]]] = None,
         groupby: Optional[list[tuple[str, Literal["asc", "desc"]]]] = None,
     ) -> list[dict[str, Any]]:
+        if not AbstractLpdbSession._validate_datatype_name(lpdb_datatype):
+            raise ValueError(f'Invalid LPDB data type: "{lpdb_datatype}"')
         lpdb_response = requests.get(
             AbstractLpdbSession.BASE_URL + lpdb_datatype,
             headers=self._get_header(),