Skip to content

Commit 7b3f900

Browse files
test: replace em-dashes with ASCII hyphens to avoid bidi/hidden Unicode warning
1 parent 272e6ef commit 7b3f900

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

src/ElectronNET.IntegrationTests/Tests/MigrationChecksTargetsTests.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
namespace ElectronNET.IntegrationTests.Tests;
44

55
/// <summary>
6-
/// Unit tests for ElectronNET.MigrationChecks.targets no Electron runtime required.
6+
/// Unit tests for ElectronNET.MigrationChecks.targets - no Electron runtime required.
77
/// Covers GitHub issue #1035: System.IO.File.ReadAllLines is not available as an MSBuild
88
/// property function on all platforms (e.g. macOS GitHub Actions), causing MSB4185.
99
/// </summary>
@@ -53,7 +53,7 @@ private static string FindTargetsFile()
5353
[Fact]
5454
public void MigrationChecksTargets_ShouldNotUseReadAllLines()
5555
{
56-
// The file must exist if this fails the path constant above is wrong.
56+
// The file must exist - if this fails the path constant above is wrong.
5757
File.Exists(TargetsFilePath).Should().BeTrue(
5858
$"targets file must exist at '{TargetsFilePath}'");
5959

@@ -69,7 +69,7 @@ public void MigrationChecksTargets_ShouldNotUseReadAllLines()
6969
}
7070

7171
// -----------------------------------------------------------------------
72-
// Functional build test verifies no MSB4185 at runtime
72+
// Functional build test - verifies no MSB4185 at runtime
7373
// (RED on platforms where ReadAllLines is restricted, GREEN after fix)
7474
// -----------------------------------------------------------------------
7575

@@ -87,7 +87,7 @@ await File.WriteAllTextAsync(
8787

8888
// Create a minimal csproj that only imports the migration checks targets.
8989
// We deliberately import just that one targets file to keep the build fast.
90-
// Note: MSBuildProjectDirectory is a reserved MSBuild property it must not be
90+
// Note: MSBuildProjectDirectory is a reserved MSBuild property - it must not be
9191
// redefined manually. MSBuild sets it automatically to the csproj's folder (tempDir).
9292
var targetsPathEscaped = TargetsFilePath.Replace("'", "&apos;");
9393
await File.WriteAllTextAsync(
@@ -99,10 +99,10 @@ await File.WriteAllTextAsync(
9999
</Project>
100100
""");
101101

102-
// ACT run the Build target
102+
// ACT - run the Build target
103103
var (exitCode, output) = await RunDotnetBuildAsync(tempDir);
104104

105-
// ASSERT the build must succeed and must not produce MSB4185
105+
// ASSERT - the build must succeed and must not produce MSB4185
106106
exitCode.Should().Be(0,
107107
$"the temporary MSBuild project should build successfully. Full build output:\n{output}");
108108

0 commit comments

Comments
 (0)