Fix dead-lock on shutdown

epsitec · epsitec · commit bfd51e64f710 · 2026-01-31T15:37:52.000+01:00
diff --git a/src/ElectronNET.AspNet/Runtime/Controllers/RuntimeControllerAspNetDotnetFirstSignalR.cs b/src/ElectronNET.AspNet/Runtime/Controllers/RuntimeControllerAspNetDotnetFirstSignalR.cs
@@ -163,7 +163,12 @@ private async void OnElectronHostReady()
 
         private void SignalRFacade_Disconnected(object sender, EventArgs e)
         {
-            this.HandleStopped();
+            // IMPORTANT: Do NOT call HandleStopped synchronously here!
+            // This event fires from within SignalR's OnDisconnectedAsync, and calling
+            // StopApplication() synchronously causes a deadlock: the host waits for
+            // OnDisconnectedAsync to complete, but we're waiting for the host to stop.
+            // Fire and forget to break the deadlock.
+            _ = Task.Run(() => this.HandleStopped());
         }
 
         private void ElectronProcess_Stopped(object sender, EventArgs e)

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,12 @@ private async void OnElectronHostReady()`
`163`	`163`
`164`	`164`	`private void SignalRFacade_Disconnected(object sender, EventArgs e)`
`165`	`165`	`{`
`166`		`- this.HandleStopped();`
	`166`	`+ // IMPORTANT: Do NOT call HandleStopped synchronously here!`
	`167`	`+ // This event fires from within SignalR's OnDisconnectedAsync, and calling`
	`168`	`+ // StopApplication() synchronously causes a deadlock: the host waits for`
	`169`	`+ // OnDisconnectedAsync to complete, but we're waiting for the host to stop.`
	`170`	`+ // Fire and forget to break the deadlock.`
	`171`	`+ _ = Task.Run(() => this.HandleStopped());`
`167`	`172`	`}`
`168`	`173`
`169`	`174`	`private void ElectronProcess_Stopped(object sender, EventArgs e)`