Merge #1544: Elem 23.3.3 final

0ecea5c Update manpages (Pablo Greco)
1d76780 Bump version to 23.3.3 final (Pablo Greco)
6e079ea updated documentation for elements chain types (Tom Trevethan)
56b2572 enabled > 21m for issued assets in GUI amount field (Tom Trevethan)

Pull request description:

  Updates master to 8db19e9, which fixes a GUI issue after ELIP 203 and a small documentation fix.

  Also and bumps version/manpages for release

ACKs for top commit:
  tomt1664:
    Tested ACK 0ecea5c
  delta1:
    ACK 0ecea5c; tested locally

Tree-SHA512: 5493957cae60b0dd11f28d8ff560f25bff6a27b88f19af98ddd8c7c0b634d784daea459ff487d09a54ae94663633e20ee9d5fd1e20eb205184e448616dd81428

Author: delta1

configure.ac

@@ -2,7 +2,7 @@ AC_PREREQ([2.69])
 define(_CLIENT_VERSION_MAJOR, 23)
 define(_CLIENT_VERSION_MINOR, 3)
 define(_CLIENT_VERSION_BUILD, 3)
-define(_CLIENT_VERSION_RC, 2)
+define(_CLIENT_VERSION_RC, 0)
 define(_CLIENT_VERSION_IS_RELEASE, true)
 define(_COPYRIGHT_YEAR, 2026)
 define(_COPYRIGHT_HOLDERS,[The %s developers])

doc/man/elements-cli.1

@@ -1,5 +1,5 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH ELEMENTS-CLI "1" "March 2026" "elements-cli v23.3.3" "User Commands"
+.TH ELEMENTS-CLI "1" "April 2026" "elements-cli v23.3.3" "User Commands"
 .SH NAME
 elements-cli \- manual page for elements-cli v23.3.3
 .SH SYNOPSIS
@@ -146,7 +146,7 @@ Chain selection options:
 \fB\-chain=\fR<chain>
 .IP
 Use the chain <chain> (default: liquidv1). Reserved values: main, test,
-signet, regtest, liquidv1, liquidv1test
+signet, regtest, liquidv1, liquidv1test, liquidtestnet
 .HP
 \fB\-con_blockheightinheader\fR
 .IP

doc/man/elements-qt.1

@@ -1,5 +1,5 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH ELEMENTS-QT "1" "March 2026" "elements-qt v23.3.3" "User Commands"
+.TH ELEMENTS-QT "1" "April 2026" "elements-qt v23.3.3" "User Commands"
 .SH NAME
 elements-qt \- manual page for elements-qt v23.3.3
 .SH SYNOPSIS
@@ -656,7 +656,7 @@ confidential addresses.(default: lq)
 \fB\-chain=\fR<chain>
 .IP
 Use the chain <chain> (default: liquidv1). Reserved values: main, test,
-signet, regtest, liquidv1, liquidv1test
+signet, regtest, liquidv1, liquidv1test, liquidtestnet
 .HP
 \fB\-con_blockheightinheader\fR
 .IP

doc/man/elements-tx.1

@@ -1,5 +1,5 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH ELEMENTS-TX "1" "March 2026" "elements-tx v23.3.3" "User Commands"
+.TH ELEMENTS-TX "1" "April 2026" "elements-tx v23.3.3" "User Commands"
 .SH NAME
 elements-tx \- manual page for elements-tx v23.3.3
 .SH SYNOPSIS
@@ -39,7 +39,7 @@ Chain selection options:
 \fB\-chain=\fR<chain>
 .IP
 Use the chain <chain> (default: liquidv1). Reserved values: main, test,
-signet, regtest, liquidv1, liquidv1test
+signet, regtest, liquidv1, liquidv1test, liquidtestnet
 .HP
 \fB\-con_blockheightinheader\fR
 .IP

doc/man/elements-util.1

@@ -1,5 +1,5 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH ELEMENTS-UTIL "1" "March 2026" "elements-util v23.3.3" "User Commands"
+.TH ELEMENTS-UTIL "1" "April 2026" "elements-util v23.3.3" "User Commands"
 .SH NAME
 elements-util \- manual page for elements-util v23.3.3
 .SH SYNOPSIS
@@ -24,7 +24,7 @@ Chain selection options:
 \fB\-chain=\fR<chain>
 .IP
 Use the chain <chain> (default: liquidv1). Reserved values: main, test,
-signet, regtest, liquidv1, liquidv1test
+signet, regtest, liquidv1, liquidv1test, liquidtestnet
 .HP
 \fB\-con_blockheightinheader\fR
 .IP

doc/man/elements-wallet.1

@@ -1,5 +1,5 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH ELEMENTS-WALLET "1" "March 2026" "elements-wallet v23.3.3" "User Commands"
+.TH ELEMENTS-WALLET "1" "April 2026" "elements-wallet v23.3.3" "User Commands"
 .SH NAME
 elements-wallet \- manual page for elements-wallet v23.3.3
 .SH DESCRIPTION
@@ -63,7 +63,7 @@ Chain selection options:
 \fB\-chain=\fR<chain>
 .IP
 Use the chain <chain> (default: liquidv1). Reserved values: main, test,
-signet, regtest, liquidv1, liquidv1test
+signet, regtest, liquidv1, liquidv1test, liquidtestnet
 .HP
 \fB\-con_blockheightinheader\fR
 .IP

doc/man/elementsd.1

@@ -1,5 +1,5 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH ELEMENTSD "1" "March 2026" "elementsd v23.3.3" "User Commands"
+.TH ELEMENTSD "1" "April 2026" "elementsd v23.3.3" "User Commands"
 .SH NAME
 elementsd \- manual page for elementsd v23.3.3
 .SH SYNOPSIS
@@ -656,7 +656,7 @@ confidential addresses.(default: lq)
 \fB\-chain=\fR<chain>
 .IP
 Use the chain <chain> (default: liquidv1). Reserved values: main, test,
-signet, regtest, liquidv1, liquidv1test
+signet, regtest, liquidv1, liquidv1test, liquidtestnet
 .HP
 \fB\-con_blockheightinheader\fR
 .IP

src/chainparamsbase.cpp

@@ -22,7 +22,7 @@ const std::string CBaseChainParams::DEFAULT = CBaseChainParams::LIQUID1;
 
 void SetupChainParamsBaseOptions(ArgsManager& argsman)
 {
-    argsman.AddArg("-chain=<chain>", "Use the chain <chain> (default: liquidv1). Reserved values: main, test, signet, regtest, liquidv1, liquidv1test", ArgsManager::ALLOW_ANY, OptionsCategory::CHAINPARAMS);
+    argsman.AddArg("-chain=<chain>", "Use the chain <chain> (default: liquidv1). Reserved values: main, test, signet, regtest, liquidv1, liquidv1test, liquidtestnet", ArgsManager::ALLOW_ANY, OptionsCategory::CHAINPARAMS);
     argsman.AddArg("-regtest", "Enter regression test mode, which uses a special chain in which blocks can be solved instantly. "
                  "This is intended for regression testing tools and app development. Equivalent to -chain=regtest.", ArgsManager::ALLOW_ANY | ArgsManager::DEBUG_ONLY, OptionsCategory::CHAINPARAMS);
     argsman.AddArg("-testactivationheight=name@height.", "Set the activation height of 'name' (segwit, bip34, dersig, cltv, csv). (regtest-only)", ArgsManager::ALLOW_ANY | ArgsManager::DEBUG_ONLY, OptionsCategory::DEBUG_TEST);

src/qt/bitcoinamountfield.cpp

@@ -124,11 +124,11 @@ class AmountSpinBox: public QAbstractSpinBox
         val.second = val.second + steps * currentSingleStep;
         val.second = qMax(val.second, CAmount(0));
         val.second = qBound(m_min_amount, val.second, m_max_amount);
-        // FIXME: Add this back in when assets can have > MAX_MONEY
-        // if (val.first == Params().GetConsensus().pegged_asset)
-        {
-            val.second = qMin(val.second, BitcoinUnits::maxMoney());
-        }
+        // ELEMENTS: issued assets can have values > MAX_MONEY
+        if (val.first == Params().GetConsensus().pegged_asset)
+            {
+                val.second = qMin(val.second, BitcoinUnits::maxMoney());
+            }
         setValue(val);
     }
 
@@ -228,8 +228,8 @@ class AmountSpinBox: public QAbstractSpinBox
         bool valid = GUIUtil::parseAssetAmount(current_asset, text, currentUnit, &val);
         if(valid)
         {
-            // FIXME: Add this back in when assets can have > MAX_MONEY
-            if (val < 0 || (val > BitcoinUnits::maxMoney() /*&& current_asset == Params().GetConsensus().pegged_asset*/)) {
+            // ELEMENTS: issued assets can have values > MAX_MONEY
+            if (val < 0 || (val > BitcoinUnits::maxMoney() && current_asset == Params().GetConsensus().pegged_asset)) {
                 valid = false;
             }
         }

src/rpc/blockchain.cpp

@@ -1672,7 +1672,7 @@ RPCHelpMan getblockchaininfo()
                 RPCResult{
                     RPCResult::Type::OBJ, "", "",
                     {
-                        {RPCResult::Type::STR, "chain", "current network name (main, test, signet, regtest)"},
+                        {RPCResult::Type::STR, "chain", "current network name (main, test, signet, regtest, liquidv1, liquidv1test, liquidtestnet)"},
                         {RPCResult::Type::NUM, "blocks", "the height of the most-work fully-validated chain. The genesis block has height 0"},
                         {RPCResult::Type::NUM, "headers", "the current number of headers we have validated"},
                         {RPCResult::Type::STR, "bestblockhash", "the hash of the currently best block"},