pubkey: fix bug in VerifySchnorr introduced in merge of bitcoin/bitcoin#22448 in 09333e2

jamesdorfman · jamesdorfman · commit 47dff66fa602 · 2023-11-03T20:50:42.000Z
diff --git a/src/pubkey.cpp b/src/pubkey.cpp
@@ -208,7 +208,7 @@ bool XOnlyPubKey::VerifySchnorr(const Span<const unsigned char> msg, Span<const
     assert(sigbytes.size() == 64);
     secp256k1_xonly_pubkey pubkey;
     if (!secp256k1_xonly_pubkey_parse(secp256k1_context_verify, &pubkey, m_keydata.data())) return false;
-    return secp256k1_schnorrsig_verify(secp256k1_context_verify, sigbytes.data(), msg.begin(), 32, &pubkey);
+    return secp256k1_schnorrsig_verify(secp256k1_context_verify, sigbytes.data(), msg.data(), msg.size(), &pubkey);
 }
 
 // ELEMENTS: this is preserved from an old version of the Taproot code for use in OP_TWEAKVERIFY

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,7 @@ bool XOnlyPubKey::VerifySchnorr(const Span<const unsigned char> msg, Span<const`
`208`	`208`	`assert(sigbytes.size() == 64);`
`209`	`209`	`secp256k1_xonly_pubkey pubkey;`
`210`	`210`	`if (!secp256k1_xonly_pubkey_parse(secp256k1_context_verify, &pubkey, m_keydata.data())) return false;`
`211`		`- return secp256k1_schnorrsig_verify(secp256k1_context_verify, sigbytes.data(), msg.begin(), 32, &pubkey);`
	`211`	`+ return secp256k1_schnorrsig_verify(secp256k1_context_verify, sigbytes.data(), msg.data(), msg.size(), &pubkey);`
`212`	`212`	`}`
`213`	`213`
`214`	`214`	`// ELEMENTS: this is preserved from an old version of the Taproot code for use in OP_TWEAKVERIFY`