fix undefined behavior in confidential commitment serialization

instagibbs · instagibbs · commit 61c54913c96c · 2018-09-25T19:57:36.000-04:00
diff --git a/src/primitives/transaction.h b/src/primitives/transaction.h
@@ -56,8 +56,9 @@ class CConfidentialCommitment
             }
             vchCommitment[0] = version;
         }
-        if (vchCommitment.size() > 1)
-            READWRITE(REF(CFlatData(&vchCommitment[1], &vchCommitment[vchCommitment.size()])));
+        if (vchCommitment.size() > 1) {
+            READWRITE(REF(CFlatData(vchCommitment.data() + 1, vchCommitment.data() + vchCommitment.size())));
+        }
     }
 
     /* Null is the default state when no explicit asset or confidential

Original file line number	Diff line number	Diff line change
`@@ -56,8 +56,9 @@ class CConfidentialCommitment`
`56`	`56`	`}`
`57`	`57`	`vchCommitment[0] = version;`
`58`	`58`	`}`
`59`		`- if (vchCommitment.size() > 1)`
`60`		`- READWRITE(REF(CFlatData(&vchCommitment[1], &vchCommitment[vchCommitment.size()])));`
	`59`	`+ if (vchCommitment.size() > 1) {`
	`60`	`+ READWRITE(REF(CFlatData(vchCommitment.data() + 1, vchCommitment.data() + vchCommitment.size())));`
	`61`	`+ }`
`61`	`62`	`}`
`62`	`63`
`63`	`64`	`/* Null is the default state when no explicit asset or confidential`