add linter check to CI

Author: tomt1664

.github/workflows/ci.yml

@@ -312,3 +312,15 @@ jobs:
           path: ${{ env.CCACHE_DIR }}
           # https://github.com/actions/cache/blob/main/tips-and-workarounds.md#update-a-cache
           key: ${{ github.job }}-ccache-${{ github.run_id }}
+
+  lint:
+    name: 'lint'
+    runs-on: ubuntu-24.04
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Build lint Docker image
+        run: DOCKER_BUILDKIT=1 docker build -t bitcoin-linter --file "./ci/lint_imagefile" ./
+      - name: Run linter
+        run: docker run --rm -v $(pwd):/bitcoin bitcoin-linter

ci/test/03_test_script.sh

@@ -124,11 +124,13 @@ fi
 # === CMake build (modern path used by the fork) ===
 if [ -n "$NO_DEPENDS" ]; then
   echo "Building with CMake (NO_DEPENDS=1)..."
-  cmake -B build -S . ${CMAKE_GENERATOR:+-G "$CMAKE_GENERATOR"} "$BITCOIN_CONFIG_ALL"
+  # shellcheck disable=SC2086
+  cmake -B build -S . ${CMAKE_GENERATOR:+-G "$CMAKE_GENERATOR"} $BITCOIN_CONFIG_ALL
 else
   # depends path (still uses configure in some jobs)
   ./autogen.sh
-  ./configure "$BITCOIN_CONFIG_ALL"
+  # shellcheck disable=SC2086
+  ./configure $BITCOIN_CONFIG_ALL
 fi
 
 cmake --build build --config Release --parallel "$MAKEJOBS"

test/functional/test_framework/blocktools.py

@@ -161,7 +161,7 @@ def script_BIP34_coinbase_height(height):
     return CScript([CScriptNum(height)])
 
 
-def create_coinbase(height, pubkey=None, *, script_pubkey=None, extra_output_script=None, fees=0, nValue=50):
+def create_coinbase(height, pubkey=None, *, script_pubkey=None, extra_output_script=None, fees=0, nValue=50, retarget_period=REGTEST_RETARGET_PERIOD): # noqa: unused - used by mining_mainnet.py currently disabled
     """Create a coinbase transaction.
 
     If pubkey is passed in, the coinbase output will be a P2PK output;