Merge #1568: rpc: fix fields type in man

8165ec8 rpc: fix fields type in man (Ruslan Kasheparov)

Pull request description:

ACKs for top commit:
  tomt1664:
    ACK e559b1c tested locally

Tree-SHA512: 3d28967258450fedca14bd609b04a58f8288b6aeb4b40e92779217dc9f6aa5e9d5ac2345a1024b38d007fa96f5da103e12c7cd1207e32eb2933bbb6723248ea4

Author: tomt1664

src/rpc/blockchain.cpp

@@ -1454,14 +1454,14 @@ RPCHelpMan getblockchaininfo()
                 {RPCResult::Type::NUM, "blocks", "the height of the most-work fully-validated chain. The genesis block has height 0"},
                 {RPCResult::Type::NUM, "headers", "the current number of headers we have validated"},
                 {RPCResult::Type::STR, "bestblockhash", "the hash of the currently best block"},
-                /* ELEMENTS: not present {RPCResult::Type::NUM, "difficulty", "the current difficulty"}, */
-                {RPCResult::Type::STR_HEX, "bits", "nBits: compact representation of the block difficulty target"},
-                {RPCResult::Type::STR_HEX, "target", "The difficulty target"},
+                {RPCResult::Type::STR_HEX, "bits", /*optional=*/true, "nBits: compact representation of the block difficulty target"},
+                {RPCResult::Type::STR_HEX, "target", /*optional=*/true, "The difficulty target"},
+                {RPCResult::Type::NUM, "difficulty", /*optional=*/true, "the current difficulty"},
                 {RPCResult::Type::NUM_TIME, "time", "The block time expressed in " + UNIX_EPOCH_TIME},
                 {RPCResult::Type::NUM_TIME, "mediantime", "The median block time expressed in " + UNIX_EPOCH_TIME},
                 {RPCResult::Type::NUM, "verificationprogress", "estimate of verification progress [0..1]"},
                 {RPCResult::Type::BOOL, "initialblockdownload", "(debug information) estimate of whether this node is in Initial Block Download mode"},
-                /* ELEMENTS: not present {RPCResult::Type::STR_HEX, "chainwork", "total amount of work in active chain, in hexadecimal"}, */
+                {RPCResult::Type::STR_HEX, "chainwork", /*optional=*/true, "total amount of work in active chain, in hexadecimal"},
                 {RPCResult::Type::NUM, "size_on_disk", "the estimated size of the block and undo files on disk"},
                 {RPCResult::Type::BOOL, "pruned", "if the blocks are subject to pruning"},
                 {RPCResult::Type::BOOL, "trim_headers", "whether header trimming is enabled (-trim-headers)"},

src/rpc/node.cpp

@@ -422,7 +422,8 @@ static RPCHelpMan tweakfedpegscript()
                     RPCResult::Type::OBJ, "", "",
                     {
                         {RPCResult::Type::STR_HEX, "script", "The fedpegscript tweaked with claim_script"},
-                        {RPCResult::Type::STR, "address", "The address corresponding to the tweaked fedpegscript"},
+                        {RPCResult::Type::STR, "p2wsh", "The native segwit address for the tweaked fedpegscript"},
+                        {RPCResult::Type::STR, "p2shwsh", "The P2SH-wrapped segwit address for the tweaked fedpegscript"},
                     }
                 },
                 RPCExamples{""},
@@ -492,7 +493,11 @@ static RPCHelpMan getpakinfo()
                     {
                         {RPCResult::Type::OBJ, "block_paklist", "The PAK list loaded from latest epoch",
                         {
-                            {RPCResult::Type::ELISION, "", ""}
+                            {RPCResult::Type::ARR, "online", "Online PAK pubkeys in hex",
+                                {{RPCResult::Type::STR_HEX, "", "online pubkey"}}},
+                            {RPCResult::Type::ARR, "offline", "Offline PAK pubkeys in hex",
+                                {{RPCResult::Type::STR_HEX, "", "offline pubkey"}}},
+                            {RPCResult::Type::BOOL, "reject", "Whether peg-outs are rejected (no offline keys)"},
                         }},
                     }
                 },
@@ -516,9 +521,9 @@ static RPCHelpMan calcfastmerkleroot()
     return RPCHelpMan{"calcfastmerkleroot",
                 "\nhidden utility RPC for computing sha2 midstates\n",
                 {
-                    {"leaves", RPCArg::Type::ARR, RPCArg::Optional::NO, "array of data to compute the fast merkle root of.",
+                    {"leaves", RPCArg::Type::ARR, RPCArg::Optional::NO, "Array of 32-byte hashes to compute the fast merkle root of.",
                         {
-                            {"data", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "hex-encoded data"},
+                            {"hash", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "32-byte hex-encoded hash"},
                         }},
                 },
                 RPCResult{
@@ -548,12 +553,12 @@ static RPCHelpMan calcfastmerkleroot()
 static RPCHelpMan dumpassetlabels()
 {
     return RPCHelpMan{"dumpassetlabels",
-                "\nLists all known asset id/label pairs in this wallet. This list can be modified with `-assetdir` configuration argument.\n",
+                "\nLists all known asset label/id pairs known to this node. This list can be modified with the `-assetdir` configuration argument.\n",
                 {},
                 RPCResult{
                     RPCResult::Type::OBJ, "labels", "",
                     {
-                        {RPCResult::Type::ELISION, "", "the label for each asset id"},
+                        {RPCResult::Type::ELISION, "", "the asset id (hex) for each label"},
                     },
                 },
                 RPCExamples{
@@ -623,7 +628,7 @@ static RPCHelpMan createblindedaddress()
                     {"blinding_key", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The blinding public key. This can be obtained for a given address using `getaddressinfo` (`confidential_key` field)."},
                 },
                 RPCResult{
-                    RPCResult::Type::STR, "blinded_address", "The blinded address"
+                    RPCResult::Type::STR, "", "The blinded address"
                 },
                 RPCExamples{
             "\nCreate a blinded address\n"