rpc: fix fields description in a man in 'decodepsbt'#1560
Merged
Conversation
delta1
reviewed
Jun 24, 2026
Comment on lines
1156
to
1157
| {RPCResult::Type::NUM, "inputs_modifiable", /*optional=*/true, "Whether inputs can be modified"}, | ||
| {RPCResult::Type::NUM, "outputs_modifiable", /*optional=*/true, "Whether outputs can be modified"}, |
Member
There was a problem hiding this comment.
These should also be BOOL
Suggested change
| {RPCResult::Type::NUM, "inputs_modifiable", /*optional=*/true, "Whether inputs can be modified"}, | |
| {RPCResult::Type::NUM, "outputs_modifiable", /*optional=*/true, "Whether outputs can be modified"}, | |
| {RPCResult::Type::BOOL, "inputs_modifiable", /*optional=*/true, "Whether inputs can be modified"}, | |
| {RPCResult::Type::BOOL, "outputs_modifiable", /*optional=*/true, "Whether outputs can be modified"}, |
Member
|
ACK 91ae0e9 |
Member
|
ACK ef1d267 tested locally |
tomt1664
added a commit
to tomt1664/elements
that referenced
this pull request
Jul 10, 2026
…decodepsbt' ef1d267 rpc: fix fields type in man in 'decodepsbt' (Ruslan Kasheparov) 91ae0e9 rpc: fix fields describtion in man in 'decodepsbt' (Ruslan Kasheparov) Pull request description: Top commit has no ACKs. Tree-SHA512: 736f7ebfd3c54267aee8e7b25970a25356f9a4c38ac23caecd40a7f4b2a96c0142adc0e73bcbd6881243981297af2d5fcc68bae9023cca6179bee823d1dd9ecb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.