reckless install: check and warn if a plugin is already installed.

Author: endothermicdev

tests/test_reckless.py

@@ -274,6 +274,12 @@ def test_install(node_factory):
     print(plugin_path)
     assert os.path.exists(plugin_path)
 
+    # Try to install again - should result in a warning.
+    r = reckless([f"--network={NETWORK}", "-v", "install", "testplugpass"], dir=n.lightning_dir)
+    r.check_stderr()
+    assert r.search_stdout('already installed')
+    assert r.returncode == 0
+
 
 def test_install_cleanup(node_factory):
     """test failed installation and post install cleanup"""

tools/reckless

@@ -1746,6 +1746,20 @@ def install(plugin_name: str) -> Union[str, None]:
             LAST_FOUND = None
             return None
 
+    # Check if we already have this installed.
+    destination = Path(RECKLESS_CONFIG.reckless_dir) / name.lower()
+
+    if Path(destination).exists():
+        # should we run listinstalled first and see what's in the list?
+        installed = listinstalled(plugin_name)
+        if installed:
+            log.info(f'already installed: {list(installed.keys())[0]} in {str(destination)}')
+            return name
+        else:
+            log.warning(f'destination directory {destination} already exists.')
+            return None
+
+
     try:
         installed = _install_plugin(src)
     except FileExistsError as err:
@@ -2160,15 +2174,18 @@ def extract_metadata(plugin_name: str) -> dict:
     return metadata
 
 
-def listinstalled():
-    """list all plugins currently managed by reckless"""
+def listinstalled(name: str = None):
+    """list all plugins currently managed by reckless.  Optionally passed
+    a plugin name."""
     dir_contents = os.listdir(RECKLESS_CONFIG.reckless_dir)
     plugins = {}
     for plugin in dir_contents:
         if (Path(RECKLESS_CONFIG.reckless_dir) / plugin).is_dir():
             # skip hidden dirs such as reckless' .remote_sources
             if plugin[0] == '.':
                 continue
+            if name and name != plugin:
+                continue
             plugins.update({plugin: None})
 
     # Format output in a simple table
@@ -2201,8 +2218,9 @@ def listinstalled():
                     status = "disabled"
                 else:
                     print(f'cant handle {line}')
-        log.info(f"{plugin:<{name_len}} {md['installed commit']:<{inst_len}} "
-                 f"{md['installation date']:<11} {status}")
+        if not name:
+            log.info(f"{plugin:<{name_len}} {md['installed commit']:<{inst_len}} "
+                     f"{md['installation date']:<11} {status}")
         # This doesn't originate from the metadata, but we want to provide enabled status for json output
         md['enabled'] = status == "enabled"
         md['entrypoint'] = installed.entry