reckless: close log socket before stdout

Otherwise reckless-rpc can be concerned that the reckless
utility process didn't exit cleanly.

Author: endothermicdev

plugins/recklessrpc.c

@@ -152,6 +152,8 @@ static void reckless_conn_finish(struct io_conn *conn,
 	/* FIXME: avoid EBADFD - leave stdin fd open? */
 	if (errno && errno != 9)
 		plugin_log(plugin, LOG_DBG, "err: %s", strerror(errno));
+	struct pollfd pfd = { .fd = reckless->logfd, .events = POLLIN };
+	poll(&pfd, 1, 20); // wait for any remaining log data
 	if (reckless->pid > 0) {
 		int status = 0;
 		pid_t p;

tests/test_reckless.py

@@ -419,7 +419,7 @@ def test_tag_install(node_factory):
 
 # Note: uv timeouts from the GH network seem to happen?
 @pytest.mark.slow_test
-@pytest.mark.flaky(reruns=3)
+@pytest.mark.flaky(max_runs=3)
 def test_reckless_uv_install(node_factory):
     node = get_reckless_node(node_factory)
     node.start()

tools/reckless

@@ -2556,3 +2556,8 @@ if __name__ == '__main__':
 
     if log.capture:
         log.reply_json()
+    # Allow log streaming socket to close before process exits
+    time.sleep(0.20)
+    if log.socket:
+        log.socket.close()
+        time.sleep(0.001)