Skip to content

Commit 4f1a2ba

Browse files
rustyrussellmadelinevibes
authored andcommitted
doc: clarify release checklist.
You gotta merge the rcN PR before tagging. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
1 parent 0a8a7af commit 4f1a2ba

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

doc/contribute-to-core-lightning/release-checklist.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Here's a checklist for the release process.
4646

4747
1. Update CHANGELOG.md by changing rc(N-1) to rcN. Update the changelog list with information from newly merged PRs also.
4848
2. Update the package versions: `uv run make update-versions NEW_VERSION=v<VERSION>rcN`
49-
3. Add a PR with the rcN.
49+
3. Add a PR with the rcN, and merge it.
5050
4. Tag it `git pull && git tag -s v<VERSION>rcN && git push origin v<VERSION>rcN`.
5151
5. Pushing the tag automatically starts the "Release 🚀" CI job, creating a draft pre-release and uploading reproducible builds with their `SHA256SUMS` files signed by the project key.
5252
6. Set up the reproducible build environment by running the script `contrib/cl-repro.sh` to generate the necessary builder images.

0 commit comments

Comments
 (0)