libplugin: add macro to deprecate dynamic options

Changelog-None

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

Author: Lagrang3

plugins/libplugin.c

@@ -2244,15 +2244,25 @@ static void ld_command_handle(struct plugin *plugin,
 		else
 			val = "true";
 
-		problem = popt->handle(cmd, val, check_only, popt->arg);
-		if (problem)
+		if (!deprecated_ok(plugin->deprecated_ok, popt->name,
+				   popt->depr_start, popt->depr_end,
+				   plugin->beglist, NULL, NULL)) {
 			ret = command_fail(cmd, JSONRPC2_INVALID_PARAMS,
-					   "%s", problem);
-		else {
-			if (check_only)
-				ret = command_check_done(cmd);
-			else
-				ret = command_finished(cmd, jsonrpc_stream_success(cmd));
+					    "Configuration %s is deprecated",
+					    popt->name);
+		} else {
+
+			problem = popt->handle(cmd, val, check_only, popt->arg);
+			if (problem)
+				ret = command_fail(cmd, JSONRPC2_INVALID_PARAMS,
+						   "%s", problem);
+			else {
+				if (check_only)
+					ret = command_check_done(cmd);
+				else
+					ret = command_finished(
+					    cmd, jsonrpc_stream_success(cmd));
+			}
 		}
 		assert(ret == &complete);
 		return;

plugins/libplugin.h

@@ -629,6 +629,9 @@ void *plugin_get_data_(struct plugin *plugin);
 #define plugin_option_deprecated(name, type, description, depr_start, depr_end, set, jsonfmt, arg) \
 	plugin_option_((name), (type), (description), (set), (jsonfmt), (arg), false, (depr_start), (depr_end), false, false)
 
+#define plugin_option_deprecated_dynamic(name, type, description, depr_start, depr_end, set, jsonfmt, arg) \
+	plugin_option_((name), (type), (description), (set), (jsonfmt), (arg), false, (depr_start), (depr_end), true, false)
+
 #define plugin_option_multi(name, type, description, set, jsonfmt, arg)	\
 	plugin_option_((name), (type), (description), (set), (jsonfmt), (arg), false, NULL, NULL, false, true)