splice-script: Memleak fix on failure

In some splice script failure modes, some memory is leaked.

These don’t occur in normal operation — just when an error occurs.

This cleans up those memory leaks.

Author: ddustin

plugins/spender/splice.c

@@ -181,7 +181,11 @@ static struct command_result *splice_error_pkg(struct command *cmd,
 					       const jsmntok_t *error,
 					       struct splice_index_pkg *pkg)
 {
-	return splice_error(cmd, methodname, buf, error, pkg->splice_cmd);
+	struct command_result *res = splice_error(cmd, methodname, buf, error, pkg->splice_cmd);
+
+	tal_free(pkg);
+
+	return res;
 }
 
 static struct command_result *calc_in_ppm_and_fee(struct command *cmd,
@@ -783,6 +787,8 @@ static struct command_result *splice_signed_error_pkg(struct command *cmd,
 				     error->end - error->start);
 	abort_pkg->code = -1;
 
+	tal_free(pkg);
+
 	return make_error(cmd, abort_pkg, "splice_signed_error");
 }