lighting-cli: fix invalid json

Changelog-Fixed: lightning-cli: fix invalid json requests when input includes a numeric string with leading zeroes

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>

Author: Lagrang3

cli/lightning-cli.c

@@ -260,6 +260,13 @@ static bool is_literal(const char *arg)
 	if (arglen == 0) {
 		return false;
 	}
+	/* A string of digits with a leading zero cannot be a literal unless it
+	 * is "0". It should be passed with quotes as it might encode a hex
+	 * data. */
+	if (strspn(arg, "0123456789") == arglen && arglen > 1 &&
+	    arg[0] == '0') {
+		return false;
+	}
 	return strspn(arg, "0123456789.") == arglen
 		|| streq(arg, "true")
 		|| streq(arg, "false")

tests/test_misc.py

@@ -1011,7 +1011,6 @@ def test_malformed_rpc(node_factory):
     sock.close()
 
 
-@pytest.mark.skip
 def test_valid_json_cli(node_factory):
     """Make sure lightning-cli passes valid json values, so that rust and python plugins
     don't crash."""