fixup! splice: Remove experiemental splicing feature

Author: ddustin

doc/developers-guide/deprecated-features.md

@@ -23,6 +23,7 @@ privacy:
 | newaddr.addresstype.defaultbech32                  | Parameter          | v25.12           | v26.12         | Use `p2tr` in the response (present since v23.08 if `addresstype` is `p2tr`,  and always present since v24.12).           |
 | channel_state_changed.null_message                 | Notification Field | v25.12           | v26.12         | In channel_state_changed notification, `message` will be missing instead of `null`                                        |
 | hsmtool.getcodexsecret                             | Command            | v25.12.1         | v26.12         | Doesn't work on nodes using mnemonic secrets (v25.12 or later).  Use `getsecret` instead.                                 |
+| experimental_splicing                              | Config             | v26.04           | v27.04         | Splicing is now enabled by default                                                                                       |
 Inevitably there are features which need to change: either to be generalized, or removed when they can no longer be supported.
 
 Types of deprecation:

lightningd/options.c

@@ -1250,6 +1250,20 @@ static char *opt_set_dual_fund(struct lightningd *ld)
 	return NULL;
 }
 
+static char *opt_set_splicing(struct lightningd *ld)
+{
+	/* Show deprecation warning */
+	if (!opt_deprecated_ok(ld, "experimental_splicing", NULL,
+			       "v26.04", "v27.04"))
+		return "--experimental-splicing is now enabled by default"
+		       " enabled by default";
+
+	feature_set_or(ld->our_features,
+		       take(feature_set_for_feature(NULL,
+						    OPTIONAL_FEATURE(OPT_SPLICE))));
+	return NULL;
+}
+
 static char *opt_set_shutdown_wrong_funding(struct lightningd *ld)
 {
 	feature_set_or(ld->our_features,
@@ -1478,6 +1492,13 @@ static void register_opts(struct lightningd *ld)
 				 " and allow peers to establish channels"
 				 " via v2 channel open protocol.");
 
+	/* Deprecated: splicing is on by default now */
+	opt_register_early_noarg("--experimental-splicing",
+				 opt_set_splicing, ld,
+				 "experimental: Enables the ability to resize"
+				 " channels using splicing");
+
+
 	/* This affects our features, so set early. */
 	opt_register_early_noarg("--experimental-shutdown-wrong-funding",
 				 opt_set_shutdown_wrong_funding, ld,