chore: replace v26.03 version mentions with v26.04

Allowing deprecated API's should actually allow them in test_sql_deprecated

Author: daywalker90

.msggen.json

@@ -10847,7 +10847,7 @@
             "deprecated": null
         },
         "ListPeerChannels.channel_id": {
-            "added": "v26.03",
+            "added": "v26.04",
             "deprecated": null
         },
         "ListPeerChannels.channels[]": {

contrib/msggen/msggen/schema.json

@@ -23623,7 +23623,7 @@
             ]
           },
           "channel_id": {
-            "added": "v26.03",
+            "added": "v26.04",
             "type": "hash",
             "description": [
               "If supplied, limits the channels to just this channel_id, if it exists. Cannot be used with 'id' or 'short_channel_id'."
@@ -24173,7 +24173,7 @@
                   ],
                   "deprecated": [
                     "v25.02",
-                    "v26.03"
+                    "v26.04"
                   ]
                 },
                 "their_max_htlc_value_in_flight_msat": {
@@ -37517,7 +37517,7 @@
             ],
             "description": [
               "The channel state, in particular \"CHANNELD_NORMAL\" and \"CHANNELD_AWAITING_SPLICE\" mean the channel can be used normally.",
-              "The deprecated value 'unknown' is also present for new channels: after v26.03 this field will be omitted instead."
+              "The deprecated value 'unknown' is also present for new channels: after v26.04 this field will be omitted instead."
             ],
             "added": "pre-v0.10.1"
           },

doc/contribute-to-core-lightning/release-checklist.md

@@ -61,7 +61,7 @@ Here's a checklist for the release process.
 3. Create a PR with above changes.
 4. After the PR is merged, create and push the release tag:
    - Run `git pull`.
-   - Set the current release version in your shell (e.g., if the current release is `v26.03`): `VERSION=26.03`
+   - Set the current release version in your shell (e.g., if the current release is `v26.04`): `VERSION=26.04`
    - Create a signed, annotated tag: `git tag -a -s v$VERSION -m "v$VERSION"`
    - Push the tag: `git push origin v$VERSION`
 5. Pushing the tag will trigger the CI pipeline, which will draft the pre-release and upload the build artifacts with project-signed checksums.

doc/developers-guide/deprecated-features.md

@@ -10,9 +10,9 @@ privacy:
 | Name                                               | Type               | First Deprecated | Last Supported | Description                                                                                                               |
 |----------------------------------------------------|--------------------|------------------|----------------|---------------------------------------------------------------------------------------------------------------------------|
 | xpay.ignore_bolt12_mpp                             | Field              | v25.05           | v25.12         | Try MPP even if the BOLT12 invoice doesn't explicitly allow it (CLN didn't until 25.02)                                   |
-| listpeerchannels.max_total_htlc_in_msat            | Field              | v25.02           | v26.03         | Use our_max_total_htlc_out_msat                                                                                           |
+| listpeerchannels.max_total_htlc_in_msat            | Field              | v25.02           | v26.04         | Use our_max_total_htlc_out_msat                                                                                           |
 | wait.details                                       | Field              | v25.05           | v26.06         | Use subsystem-specific object instead                                                                                     |
-| channel_state_changed.old_state.unknown            | Notification Field | v25.05           | v26.03         | Value "unknown" is deprecated: field will be omitted instead                                                              |
+| channel_state_changed.old_state.unknown            | Notification Field | v25.05           | v26.04         | Value "unknown" is deprecated: field will be omitted instead                                                              |
 | coin_movement.tags                                 | Notification Field | v25.09           | v26.09         | Use `primary_tag` (first tag) and `extra_tags` instead                                                                    |
 | coin_movement.utxo_txid                            | Notification Field | v25.09           | v26.09         | Use `utxo` instead of `utxo_txid` & `vout`                                                                                |
 | coin_movement.txid                                 | Notification Field | v25.09           | v26.09         | Use `spending_txid` instead                                                                                               |

doc/schemas/listpeerchannels.json

@@ -32,7 +32,7 @@
         ]
       },
       "channel_id": {
-        "added": "v26.03",
+        "added": "v26.04",
         "type": "hash",
         "description": [
           "If supplied, limits the channels to just this channel_id, if it exists. Cannot be used with 'id' or 'short_channel_id'."
@@ -582,7 +582,7 @@
               ],
               "deprecated": [
                 "v25.02",
-                "v26.03"
+                "v26.04"
               ]
             },
             "their_max_htlc_value_in_flight_msat": {

doc/schemas/notification/channel_state_changed.json

@@ -66,7 +66,7 @@
         ],
         "description": [
           "The channel state, in particular \"CHANNELD_NORMAL\" and \"CHANNELD_AWAITING_SPLICE\" mean the channel can be used normally.",
-          "The deprecated value 'unknown' is also present for new channels: after v26.03 this field will be omitted instead."
+          "The deprecated value 'unknown' is also present for new channels: after v26.04 this field will be omitted instead."
         ],
         "added": "pre-v0.10.1"
       },

lightningd/peer_control.c

@@ -1197,7 +1197,7 @@ static void NON_NULL_ARGS(1, 2, 4, 5) json_add_channel(struct command *cmd,
 	json_add_amount_sat_msat(response, "dust_limit_msat",
 				 channel->our_config.dust_limit);
 	if (command_deprecated_out_ok(cmd, "max_total_htlc_in_msat",
-				      "v25.02", "v26.03"))
+				      "v25.02", "v26.04"))
 		json_add_amount_msat(response, "max_total_htlc_in_msat",
 				     channel->our_config.max_htlc_value_in_flight);
 	json_add_amount_msat(

tests/test_plugin.py

@@ -4317,11 +4317,11 @@ def test_sql(node_factory, bitcoind):
 
 
 def test_sql_deprecated(node_factory, bitcoind):
-    l1, l2 = node_factory.line_graph(2, opts=[{'allow-deprecated-apis': True}, {}])
+    l1, l2 = node_factory.line_graph(2, opts=[{'allow-deprecated-apis': True, "broken_log": "DEPRECATED API USED: listpeerchannels.max_total_htlc_in_msat"}, {}])
 
-    # Even with deprecated APIs, this isn't there.
-    with pytest.raises(RpcError, match="Deprecated column table peerchannels.max_total_htlc_in_msat"):
-        l1.rpc.sql("SELECT max_total_htlc_in_msat FROM peerchannels;")
+    # With deprecated APIs, this is there.
+    ret = l1.rpc.sql("SELECT max_total_htlc_in_msat FROM peerchannels;")
+    assert ret == {'rows': [[-1]]}
 
     # It's deprecated in l2, so that will fail!
     with pytest.raises(RpcError, match="Deprecated column table peerchannels.max_total_htlc_in_msat"):