reckless: rust rewrite

Changelog-None

Author: daywalker90

Cargo.lock

@@ -20,6 +20,7 @@ members = [
     "plugins/wss-proxy-plugin",
     "plugins/bip353-plugin",
     "plugins/currencyrate-plugin",
+    "plugins/reckless-plugin",
 ]
 
 [workspace.dependencies]

Cargo.toml

@@ -460,8 +460,7 @@ ALL_NONGEN_SRCFILES := $(ALL_NONGEN_HEADERS) $(ALL_NONGEN_SOURCES)
 BIN_PROGRAMS = \
 	       cli/lightning-cli \
 	       lightningd/lightningd \
-	       tools/lightning-hsmtool\
-	       tools/reckless
+	       tools/lightning-hsmtool
 PKGLIBEXEC_PROGRAMS = \
 	       lightningd/lightning_channeld \
 	       lightningd/lightning_closingd \
@@ -872,7 +871,7 @@ clean: obsclean
 
 # See doc/contribute-to-core-lightning/contributor-workflow.md
 PYLNS=client proto testing
-update-versions: update-pyln-versions update-reckless-version update-dot-version # FIXME: update-doc-examples
+update-versions: update-pyln-versions update-dot-version # FIXME: update-doc-examples
 	@uv lock
 
 update-pyln-versions: $(PYLNS:%=update-pyln-version-%)
@@ -910,11 +909,6 @@ pyln-build-all: pyln-build pyln-build-bolts pyln-build-grpc-proto pyln-build-wss
 update-lock:
 	uv sync --all-extras --all-groups
 
-update-reckless-version:
-	@if [ -z "$(NEW_VERSION)" ]; then echo "Set NEW_VERSION!" >&2; exit 1; fi
-	@echo "Updating tools/reckless to $(NEW_VERSION)"
-	@$(SED) -i.bak "s/__VERSION__ = '.*'/__VERSION__ = '$(NEW_VERSION)'/" tools/reckless && rm tools/reckless.bak
-
 update-dot-version:
 	@if [ -z "$(NEW_VERSION)" ]; then echo "Set NEW_VERSION!" >&2; exit 1; fi
 	echo $(NEW_VERSION) > .version

Makefile

@@ -31332,9 +31332,9 @@
       "$schema": "../rpc-schema-draft.json",
       "type": "object",
       "rpc": "reckless",
-      "title": "Issue a command to the reckless plugin manager utility",
+      "title": "Reckless, a plugin manager",
       "description": [
-        "The **reckless** RPC starts a reckless process with the *command* and *target* provided.  Node configuration, network, and lightning direrctory are automatically passed to the reckless utility."
+        "The **reckless** RPC lets you manage plugins. It has multiple commands available, best described in the **help** command."
       ],
       "request": {
         "required": [
@@ -31346,45 +31346,34 @@
             "type": "string",
             "enum": [
               "install",
+              "update",
               "uninstall",
-              "search",
+              "listavailable",
+              "listinstalled",
               "enable",
               "disable",
               "source",
-              "--version"
+              "tip",
+              "help"
             ],
             "description": [
               "Determines which command to pass to reckless",
               "  - *command* **install** takes a *plugin_name* to search for and install a named plugin.",
               "  - *command* **uninstall** takes a *plugin_name* and attempts to uninstall a plugin of the same name.",
-              "  - *command* **search** takes a *plugin_name* to search for a named plugin.",
+              "  - *command* **help** takes a *command* to display help for.",
               "..."
             ]
           },
           "target/subcommand": {
-            "oneOf": [
-              {
-                "type": "string"
-              },
-              {
-                "type": "array"
-              }
-            ],
+            "type": "string",
             "description": [
               "Target of a reckless command or a subcommand."
             ]
           },
           "target": {
-            "oneOf": [
-              {
-                "type": "string"
-              },
-              {
-                "type": "array"
-              }
-            ],
+            "type": "string",
             "description": [
-              "*name* of a plugin to install/uninstall/search/enable/disable or source to add/remove."
+              "*name* of a plugin to install/uninstall/listavailable/enable/disable or source to add/remove."
             ]
           }
         }
@@ -31399,7 +31388,7 @@
           "result": {
             "type": "array",
             "items": {
-              "type": "string"
+              "type": "object"
             },
             "description": [
               "Output of the requested reckless command."

contrib/msggen/msggen/schema.json

@@ -334,6 +334,11 @@ connections. Default is 9736.
   them over grpc. If buffer overflow occurs some notifications will not
   be delivered.
 
+* **reckless-dir**=*DIR*
+
+  Set the working directory for reckless, where repositories, metadata, reckless-installed
+  plugins, and a reckless-installed config is stored. Defaults to `lightning-dir/../reckless`
+
 ### Lightning node customization options
 
 * **recover**=*mnemonic*

doc/lightningd-config.5.md

@@ -1,5 +1,5 @@
-reckless -- Issue a command to the reckless plugin manager utility
-==================================================================
+reckless -- Reckless, a plugin manager
+======================================
 
 SYNOPSIS
 --------
@@ -9,27 +9,22 @@ SYNOPSIS
 DESCRIPTION
 -----------
 
-The **reckless** RPC starts a reckless process with the *command* and *target* provided.  Node configuration, network, and lightning direrctory are automatically passed to the reckless utility.
+The **reckless** RPC lets you manage plugins. It has multiple commands available, best described in the **help** command.
 
-- **command** (string) (one of "install", "uninstall", "search", "enable", "disable", "source", "--version"): Determines which command to pass to reckless
+- **command** (string) (one of "install", "update", "uninstall", "listavailable", "listinstalled", "enable", "disable", "source", "tip", "help"): Determines which command to pass to reckless
    - *command* **install** takes a *plugin\_name* to search for and install a named plugin.
    - *command* **uninstall** takes a *plugin\_name* and attempts to uninstall a plugin of the same name.
-   - *command* **search** takes a *plugin\_name* to search for a named plugin.
+   - *command* **help** takes a *command* to display help for.
  ...
-- **target/subcommand** (one of, optional): Target of a reckless command or a subcommand.:
-  - (string)
-  - (array)
-- **target** (one of, optional): *name* of a plugin to install/uninstall/search/enable/disable or source to add/remove.:
-  - (string)
-  - (array)
+- **target/subcommand** (string, optional): Target of a reckless command or a subcommand.
+- **target** (string, optional): *name* of a plugin to install/uninstall/listavailable/enable/disable or source to add/remove.
 
 RETURN VALUE
 ------------
 
 On success, an object is returned, containing:
 
-- **result** (array of strings): Output of the requested reckless command.:
-  - (string, optional)
+- **result** (array of objects): Output of the requested reckless command.:
 - **log** (array of strings): Verbose log entries of the requested reckless command.:
   - (string, optional)