feat: CHS proofreading and update to 2.8.21#167
Merged
Conversation
SlimeSB
commented
Jul 26, 2025
| "sounds.biomancy.item.bone_marrow.drink": "嘬吸骨髓", | ||
| "sounds.biomancy.item.impaler.shoot": "射出穿刺物", | ||
| "sounds.biomancy.item.impaler.hit": "穿刺炮：击中", | ||
| "sounds.biomancy.item.impaler.impact": "生物：碰撞", |
Contributor
Author
There was a problem hiding this comment.
The sound 'impaler.impact' will play when I hit a mob and it impacts against a block, right?
So should it be called 'mob impact' instead?
Owner
There was a problem hiding this comment.
Actually i used a similar naming scheme to minecraft. And the impact sound is actually for block hits and the hit sound is for mobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.