Skip to content

"fixed" sampling with old <eos> method#12

Open
lucidrains wants to merge 33 commits into
mainfrom
eos-with-sampling
Open

"fixed" sampling with old <eos> method#12
lucidrains wants to merge 33 commits into
mainfrom
eos-with-sampling

Conversation

@lucidrains

Copy link
Copy Markdown

@sdtblck yet another try

@lucidrains

Copy link
Copy Markdown
Author

@sdtblck if this still doesn't work, we'll give the non-cached version on the same branch a try

@lucidrains

Copy link
Copy Markdown
Author

@sdtblck hmm, i don't see the logits mask being used at all, so it's likely going to be still broken with this old way of doing things

@CLAassistant

CLAassistant commented Apr 23, 2023

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 5 committers have signed the CLA.

❌ sid
❌ ConnorJL
❌ kingoflolz
❌ leogao2
❌ lucidrains


sid seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants