From 9686c9b06446b1bd03fec79dc3ccefc92aa3d599 Mon Sep 17 00:00:00 2001 From: Louis Date: Wed, 8 Oct 2025 16:44:01 +0100 Subject: [PATCH 1/2] fix temp in demo --- README.md | 2 +- demo/demo_mlx.py | 2 +- example-prompts/smooth_jazz.mid | Bin 6961 -> 4542 bytes 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 6a0e4b9..008bfd5 100644 --- a/README.md +++ b/README.md @@ -94,7 +94,7 @@ python ./demo/demo_mlx.py \ --midi_control_signal 67 \ --midi_reset_control_signal 66 \ --temp 0.9 \ - --min_p 0.03 + --min_p 0.05 ``` A MIDI input device is not strictly required to play around with the demo: By using the `--midi_path` and `--midi_through` arguments you can mock real-time input by playing from a MIDI file. All that is required are MIDI drivers (e.g., CoreMIDI) and a virtual software instrument (e.g., Fluidsynth, Pianoteq) to render the output. In this mode, you can initiate the model takeover by pressing the enter key. diff --git a/demo/demo_mlx.py b/demo/demo_mlx.py index 9e08dbf..37f4f2f 100644 --- a/demo/demo_mlx.py +++ b/demo/demo_mlx.py @@ -696,7 +696,7 @@ def decode_tokens( logits[:, tokenizer.tok_to_id[tokenizer.eos_tok]] = float("-inf") if temperature > 0.0: - next_token_ids = sample_min_p(logits, min_p).flatten() + next_token_ids = sample_min_p(logits / temperature, min_p).flatten() else: next_token_ids = mx.argmax(logits, axis=-1).flatten() diff --git a/example-prompts/smooth_jazz.mid b/example-prompts/smooth_jazz.mid index 73f31a925fd25143d1490b0c58c222400b811761..36aaa3c7ebf56eb6fe59db34fa0663f05d0e6349 100644 GIT binary patch literal 4542 zcmai%U27c46^3g!#tDVdDxooM!xq9NFRhOmjoPj08L2g%p0UQGk?h?SLIh*P5{wa> z5QNza6NF87D<+rq7jl=&{R#O|x!*jeYBY8>S#lwy8C9K+_q^vlr=Fc&yi!Wt=I67| z{`Kti%^#Ke?LX8{-~Q^?e_v7mRPMy}6TKEkSzHZ%9KNqsT#?tCgIsr#`rfdp&&whj zC^cy5La8FrJ689V%9QFTHB>4!>c^p~R=9b`jf-Y^jZ+*~s#I!+|0^|Cazwj>LT_4C zSluno_&|dVOp7{?9Ip>x*5Z21#?a8ejjepG3r;8ObYT!QoYZzIr`;|4I;8 z>LhxQ)=MDpAmkge3g^kkxDt$FEp}V_k*)3o^u|R!3wFtb)G__Yn>Ox|(O|F@YcS{= zb%R0XrbW|k8$B!ZxTU#PCJ{byNGia<{jCt)6a+5aj&1Hw%Lo$%&P{zjDVp1fk-B^e zJL{k=`(K`fWtCs@B6gp5PvT4;1xJ1oP`LrGL1wm-Y!Rb8{g_svak&;#GZqqi$ z4^6Ww21t)zT!0ybipxEv9(u>d9h7>_sw`0h_+uxyuJ1WwKPc-iWTeu;0blvDjffPGi+GZ$q?Y+1!TE!(0N&{Ry0gumG_)&$AWlJ>xTM-nqvuy&3B+UlCY5PX;3a z9o$J{Tt9Jv(S**q$KFul29zSv8&H9!@R~_&&0F(|7r&LR3i; zt+;8~j5tov5aT};XTyjV?Z$dwplFo|KhPapUyMr_O@nu=XvcycSO5qRirla;JIZV* z;bHY!u)d(m1B7ukX?pzvt_sANonruQT%E%}WG`G%*7rJT1Pn{SAmZ~g7AC=WXke^(Bv79tuRh~c!6e)*P@()mdP*zF zRT(Kw-A>Yc5Bz;H5FI+IUP9Vim`(@=Mj+(HT)qM$@Q0;Ob;w)F1ktOO(LsMmWxs{~ zNRX*7O5!1%dlm6P?a*9$R#b+29=e|iQ3aK%fg7hmdYBO$<5PD#7C>%9Cuq<|>5=qa za&yIPnx_5G)NeRkmi`xau<@z%a2hE^ci>t}bSF#9LzPnUddW-AM5y8iW{RNbp4CWB z3iZ7nkzo)c$?Yw4ZdRoW3*E9Rw|Xz}H?71A68K)ok5mjfd7Q#)(HzJQZhNUDf{Bl^ zgW>Bxc!@zWIFtmHi2~6VDkSm*ODD7&V!i1{s;G|8fG7zdfE@HjyB!s6sOod!_9fhI z?#n!}GS3F~!{=*2oQm)e4YxzbE_$Qh9KKIoC$6tD*wbq67kSg$gEJ{3k!}{BeG@In z&UO4tVT5;oal^FvL11d>1l2~n8C6z@hAT?Mgd{CF4o39@H%gm#90x#nv=DEjhiPbN znP>Ivu++T-axheA&qJWL>adIgmSMVaceF4JL9$kJyl)lLW7jtAJB&VxF?hP96WHFrRvE< zug9Vsl13{Eb9@f&UGLyv(yaCpb$H}4N&GUU&5_0t)LHV>sV=uvbgZho!XQKV^N=tdz^9GKfbyb* z@R3F(RIXwK`=NjnFCTPOd$%Ql4wL%o_^28jmDTHhOC##DiS8!#IZh7CSFmJOypq2s zZ=X)0QA#ICJM?WN@S6JG!BMlESpB5*k*5JnIRaQj76O8)P>wodk5I4&Uyp8L@+0DN zl)7n;a?OqkuX;$2ky?k|!r7cuLcjrw;PqDrxklJw2a>%<&wWCtkTLb~dV3-&ayw^A zJ}sLzaRnhGw4i07rL_a0uZ(_d)u^Q~UPL!LW``BAYn$as+8j@Fy%F)Ws4sXUT%lQ$ zoXx7f%5BqQu|`nX*Y~NT(Yw+7tr0eZMQzw#xW|eH6kmB7X_u>dNqBVEWu&$me^~D) z2CXC7ERKT81({s+WtH64Ie$mq5$7E+!%Ka#$Wt@)m%T0fbO~q7=PhjMHwM=ICM+v5|NX<~vTRiWDQn zA-#_7^PX(Ct)7(;dj+?C=`EFV`VGsB_I)&8X`(^gd^attlSxs%=0$Z-%AO|~oBy}c zNU|p`O`7E~gPhsK1__jwl}2m;F38gQ1n&phz-^;3Wnow{c{s^dV}D_#k-mBjAsEo) zlh&sYftBXwHI@3Ol)OH0*YtQejd(aM%h|jcv8IF+fR?o_lgEB@n^<@sor|F&Y#V5u zbT)CeBdF=EbAMSx&p(M64!jPFRwSZtKCUwOSZo9snrg?Qa zORColmuIbd^Xs%8eoG7OE1adL$@Ozcy!J(UmVQ|2AQ~B!{_=|=N9y{tUBSYs=I_V52Wt^P~>W6*5HK|53{q0U1){cGoAwbl$$oA(lX7MXIO z)S##rMg!k zY6SyI^^}T~dZ5&zQr{_6Dz&E6u2N5w`n99%G^gKb`lTK93fsRQp7fRK59=NOvHmm* z=8bwB>rSj!jU0kK4osBFSm|-QX)*qWc$Y$5 zmWG}8`9`UERw=cr)Q(ac&QQ`kRT*$xG1@iQ9*I9(R@-JrDZhWzXvT+9L7 za&)p+1_D!RdSP{Rcu)=YhgD}!sl80&>atRKsFp*u5e2y2YXu${wqOwqmXz95YF4SC zQgccjIxlpyuk1tIu(z8*Q5}KCdYJ`9s25FuqXgIvH7IjJZsdGyg9N8>vS8Y0Z@*#R zu{fUT%_LY2^|#>2RyMg@03rzbz;)AC_Dqg^*=!~Chaxpgh7<>RC@y0Kyg&+Pzx7AF zWbLTgEXLbdn`@~&(aT0}gpefQ2#ovK#2waFon|x9OW~)ah>V;MQ$o$*ZKE>q2?I#s zcYp(tu<1d%ZZefI9fkcbHxvZCs8`y%LXRvC~9DwESLH%Yms^7DkuM5M9$sP{K z!|GfTRaR@VbZGPW@FFqx;r>tywrrSK74JEU#aQM*qQ)29>?*qgK%d?=pyAf5G7a*` z1tA%(I=ke4U#b0JJv+!8XA;dycs6gu{%UBvaa>5gKu@-v<& zs++>qsU`{QH-dbxsO}2Y3p%!N4zhGauHk+{XIr z2Q52IfLp0BX?-!OyTX(MvR2)p=<{}BZw#{f>nEY=mztvPhKUdPf#Zs&1$(@-kUS#X z{(@4@iPg3DA|#uH>s%6P*VaKRMeB8|SDuOcqJAXGm!Wm>Nj zWc+-Piq>)#b+iidvEDSg2tWVSO++dHZ6lOiQ&e-U`h%b=J5#44p|EqYMXl(p<<&$8 z+76`VamJ?`GP1&= zv*t;n=cI)6T5Dnqes~eM=zRRV(4fH zfCQS7qH8SdZRbvr)URg3YC*D)RcnqH)$4YmJK3a#@F~Lv`G;MR5orPN`c{MQCFzcJ zf(*v>qU0{FcQ|QK3TEx3?tVAaPf|@Zu|UQh8_24w`<-K19l31MVqn?vYt*d7b@yAy zH8`jic7CW{7m+AT7D>E`34Fu!or4;Va@B$khGS<#H#=Ty$A1%`dZm;vM0Y^cv%vIW zUP@BYDs5--B?avHGW76nPQ*Dv21@!e*`1>s_# zSP?Lk@xyXj4f>>-T=MaHzD0|LP|~CYkE7_CH-O9v_~c0=IFM&M-6RwOIa`gZo7_-2 znms)z>)BzZxjS%VQ<^o=L)^y#H_mUJ0ueDqTLERTo+S#hOJ)#l4&N$*)Ljg!n>ej@ zB?C;p!5BJBv7ouK+}&f}IRejxpF1yM%IC=P# z{fojldD#(p5tHB%PDEZrrX|+|P7w;|apQ;`G>=w+5bi}2J)%Eccm3OM^~K&`-CNO< zY$7Q-b)7gKk(PT`l4EJZVb)??zgf=gyRFim^@etYB+Sf3LATWX1J?r()769kjfw1c z!ZHa_l0q3TXH};hRtu=g*Ms4es^E*X!xQQJe^mvvKP6YHQb@^2F5T6*k=EsMLI_WJ!ABTRo-b)Y+(9F_rM)8pa~B|!Y*9z-9A5lfz;3!Yxy-YUIl zQSV4_Ez>XRS7o8+TGi`WW2aW43lKuHxLs)P@@U*%3dc*bHvBx0MxR>a*2ihXIB3u{ z@A`GVLD$y@Re(6)1jqKEro;cLq#GnD2 zq45|I5T|1k8YS*#l+~^@5z~!Gb+f>&XRs=(g#q-M@Q8MZTZI|7(7A~K2@hH6ee(zj zHHA|r4FOO%Qp2tb=TwZixe5ECv`64^)Nc!$xcW& zlh5UTQQdJP5#zl?;6|m0WZ@)Bc3jBL5R=Ii27Xy-@SK8^xLi<-QzG1bVJc-#dweOs zayw5-(w^ZJD_+u)kL1^(J)1X)XMqO;V;&CxcBl1~?v-xvt!A3laQqihVXk^p&tm1$ zF|L|{7j%;tqBI$52I#TKf7f;Zv& zggLUoJ)0jTcKR^2xA*znl@TSeEB(ygmV9LPprVXXm*Zh z7zpX83}U0x5R7nF{!ko@lp2-QP1(uKfvypv^!$-#+S)IxJ3xJtBcZNal-SGrtqb`> zTAjOH_1BSf1imkqQCnznAk45U!u!llfy|9Q81&MMw$fgc1doK0MxYBr_vF}Or?)eE z<0*o?Q`p-FneE3)eV^Ku=cV>-(Q3p4lUk3tE>3<>5(OdHhsU&a^ew55|RcW!rLaC{oVXTSrAT4>Hm>S>;4>{AY|3;yz4*NvvBB>I$uiWMv-ng7`dxL&* zBncqe@5$hECE=|r10nI7MLYuS$Lg2>ILW;owN3St+fpq+m;tK630wo4?vC0rTE28O zfkv$Tm0%=<$gaFlMzTDt&XKyqLhr@Q(7^zC_vQwk12fN5aG;Fj6d9Hh*VF?ibi>c_fAqa;&{s0Xa^9Z*>P zEMzIGBl)0|7ft4Vt7lyf#!I;5v{0^ix3#+aeRe7pKPv6*LlrD@L(Cg}n8{PlAd-fK z8tfU)6#4TSiwW$pACKt?@ECW$_Z~}kciPD2geKx@KaUQK`mOpnY1OazQc&fpibcak z86zk!jd$XX13upzFws;C@)Gz4wPCK}Zo6mHlQ4MHn)Eq1=YbToIGZVWn+cIVe3mzX zn2A|(E4$s?{K)k&_pV*_1Ht>{)b=@@`}wTLLoz}+AkBW5q?zZz#A_`Gctyb=f=6oQ z*sB?`-eIs<+dbgHWmw;$Uy(5~wa+*PxYZ}F)68OAN;;#}bN#a$ zzBgjhM<0LH>Y43AcbIb=qx_ERgor6FXKD4Ab0)1`GHLaglP9A2<^d0*H0p6cipVM9 zB>!ihC$`=-$n2!g%Ms=Na%{K|N0MV+l^2Y(E+E6duX{TJ^BHv4Ice+irX`nor=j)9 z4^lfdDr}x5`UNJQAsB11Ip&r2-0M0=s3dJYp|yM5^jzq*UZyd}F*t=2}c zuXsCW>^oP9c4aoakOiUbuSBI&SE<$>Pt9R{+>Y(af=WuIyQ+GfhcsijqpG7!=@%;b zF*VO)&8Ct=-E-yu#aL70zw9d9p=NLdr9MV_q)~L!27LKR0LAucm2q@{k?0g*my^&&$ zh>8AC6o-ycq%*8Kbcr+E_&@O`;GWMFNOC z$H=jHSg(V|`5>!r?UkS29+pny5)mM7L^Q}j_GSJD7Y_DF`~GzA%866j%DfpB(r1&R z0S_UuUJO)ej97Dkl68qr-0jm4R_7R_$ND*s>YajT)L!_@^pBZ_Z@^TB&KY6d3BGy` X`M$+V?Z{cnL|IvmZO^5DK2rY!X Date: Wed, 8 Oct 2025 16:45:53 +0100 Subject: [PATCH 2/2] update --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 008bfd5..e2a6318 100644 --- a/README.md +++ b/README.md @@ -93,7 +93,7 @@ python ./demo/demo_mlx.py \ --hardware ./demo/hardware/c4dm-disklavier.json \ --midi_control_signal 67 \ --midi_reset_control_signal 66 \ - --temp 0.9 \ + --temp 0.85 \ --min_p 0.05 ``` @@ -107,7 +107,7 @@ python ./demo/demo_mlx.py \ --midi_path ${MIDI_PATH} \ --midi_through \ --midi_out \ - --temp 0.9 \ + --temp 0.85 \ --min_p 0.05 ```