Make identity/FOOF write covariance dirs, fix target_modules#274
Open
smarter wants to merge 2 commits intoEleutherAI:sourcefrom
Open
Make identity/FOOF write covariance dirs, fix target_modules#274smarter wants to merge 2 commits intoEleutherAI:sourcefrom
smarter wants to merge 2 commits intoEleutherAI:sourcefrom
Conversation
This is useful for downstream code in https://github.com/smarter/memorization_kfac/tree/exps to avoid special cases.
Note that I'm not sure PEFT support is fully working in the existing codebase
since we do:
collector_args = {
"model": model.base_model, # type: ignore
"target_modules": target_modules,
Instead of `"model": model`.
smarter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for downstream code in
https://github.com/smarter/memorization_kfac/tree/exps to avoid special cases.