add missing docstrings to print_writeout and get_sample_size in evaluator_utils.py#3910
Open
RavSinghChandan wants to merge 1 commit into
Open
Conversation
Author
|
@googlebot I signed it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
print_writeoutandget_sample_sizeinlm_eval/evaluator_utils.pyare public functions used during evaluation but have no docstrings, making their purpose and expected inputs unclear without reading the implementation.print_writeout– logs the context prompt and request string for the first document in a task, useful for debugging.get_sample_size– resolves a fractional or absolute sample limit into a concrete document count.Added Google-style docstrings with Args and Returns sections matching the style used for
find_test_rootandrun_task_testsalready in this file.No logic changes.