Skip to content

Commit 8f1348d

Browse files
EliahKaganclaude
andcommitted
Cover submodule working trees in safe.directory on Cygwin
Add the gitdb and smmap submodule working tree paths to the `safe.directory` config in the Cygwin CI workflow. Without this, when GitPython opens a submodule as a `Repo` and runs `git cat-file --batch-check` against it, git rejects the repository for dubious ownership. The user-visible failure modes documented in the previous commit (`ValueError`, `IndexError`, `AssertionError`) all trace back to this rejection. The `reproduce-safe-dir` matrix on the previous commit produces failures for all three affected tests; this commit's CI run is expected to show those tests passing instead. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent cdda97b commit 8f1348d

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

.github/workflows/cygwin-test.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ jobs:
5858
run: |
5959
git config --global --add safe.directory "$(pwd)"
6060
git config --global --add safe.directory "$(pwd)/.git"
61+
git config --global --add safe.directory "$(pwd)/git/ext/gitdb"
62+
git config --global --add safe.directory "$(pwd)/git/ext/gitdb/gitdb/ext/smmap"
6163
git config --global core.autocrlf false
6264
6365
- &prepare-repo

0 commit comments

Comments
 (0)