Skip to content

Commit c42fc0b

Browse files
EliahKaganCopilot
andauthored
Word shell mention of shlex.split more carefully
To avert the mistake of not removing `shell=True` when using it. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
1 parent 010a7bb commit c42fc0b

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

git/cmd.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1222,7 +1222,8 @@ def execute(
12221222
12231223
On Unix-like systems, when migrating away from passing string commands with
12241224
``shell=True``, :func:`shlex.split` may serve as a transitional step in rare
1225-
cases, but this should be undertaken with extreme care. See the `command`
1225+
cases, but this should be undertaken with extreme care, and the resulting
1226+
sequence should then be passed with ``shell=False``. See the `command`
12261227
parameter above on the risks.
12271228
12281229
:param env:

0 commit comments

Comments
 (0)