Skip to content

Commit cb49492

Browse files
EliahKaganclaude
andcommitted
Have actions/checkout clone submodules recursively in test workflows
Set `submodules: recursive` on `actions/checkout` in the three workflows that run the test suite (cygwin-test, alpine-test, pythonpackage) so that submodule working trees are fetched in parallel by the action, not sequentially in `init-tests-after-clone.sh`. The script's `git submodule update --init --recursive` line becomes a no-op verification rather than the only mechanism for fetching submodules, and the script's other responsibilities (master branch setup, reflog history, version tags) are unaffected. The codeql and lint workflows do not run the test suite and do not need submodules; they are unchanged. This does not eliminate the dubious-ownership issue covered by later commits in this chain. `actions/checkout`'s `set-safe-directory: true` default adds only the main repository path to safe.directory, and on Cygwin that addition lands in the Windows-side global git config, not the Cygwin-side one (since `actions/checkout` runs the Node action against the Windows git binary, while Cygwin git uses its own global config under the Cygwin user's home). So the cygwin-test workflow still needs the explicit `safe.directory` entries for the gitdb and smmap working trees that subsequent commits add. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent c7648c0 commit cb49492

3 files changed

Lines changed: 3 additions & 0 deletions

File tree

.github/workflows/alpine-test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ jobs:
2929
- uses: actions/checkout@v6
3030
with:
3131
fetch-depth: 0
32+
submodules: recursive
3233

3334
- name: Set workspace ownership
3435
run: |

.github/workflows/cygwin-test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ jobs:
3737
- uses: actions/checkout@v6
3838
with:
3939
fetch-depth: 0
40+
submodules: recursive
4041

4142
- name: Install Cygwin
4243
uses: cygwin/cygwin-install-action@v6

.github/workflows/pythonpackage.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ jobs:
5353
- uses: actions/checkout@v6
5454
with:
5555
fetch-depth: 0
56+
submodules: recursive
5657

5758
- name: Set up Python ${{ matrix.python-version }}
5859
uses: actions/setup-python@v6

0 commit comments

Comments
 (0)