Commit d276fbc
Add submodules: recursive temporarily, for testing
Add `submodules: recursive` to the `actions/checkout` step in every
workflow that runs the test suite (`cygwin-test.yml`,
`pythonpackage.yml`, `alpine-test.yml`). This is **temporary** and is
reverted after the next commit's bugfix, with the explicit intent of
demonstrating that the bugfix works regardless of which mechanism
populates the submodules.
The standing decision is to NOT use `submodules: recursive` in CI:
`init-tests-after-clone.sh` is the documented setup mechanism that
downstream packagers (Arch Linux and others) rely on, and keeping it as
the sole submodule source on upstream CI catches gitpython-developers#1713-class regressions
before they reach distros. See PR gitpython-developers#1715
(gitpython-developers#1715) for the
full rationale.
The CI run on this commit is expected to show:
- Cygwin (`test-cygwin`): the safe.directory bug still triggers, with
the same `ValueError` / `IndexError` / `AssertionError` pattern as the
previous commits. The bug is independent of which process clones the
submodules; the gitdb worktree directory itself is created Admin-owned
by the outer `git clone`'s checkout phase before any submodule init
runs, regardless of which mechanism populates the submodule contents
afterward.
- Native Linux/macOS/Windows (`Python package`) and Alpine Linux
(`test-alpine`): tests pass as before. These platforms are not
affected by the bug.
Each workflow's checkout step carries an inline comment pointing at PR
gitpython-developers#1715 so the temporary nature of the change is legible at a glance.
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 91e6f96 commit d276fbc
3 files changed
Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
32 | 35 | | |
33 | 36 | | |
34 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
42 | 45 | | |
43 | 46 | | |
44 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
56 | 59 | | |
57 | 60 | | |
58 | 61 | | |
| |||
0 commit comments