Skip to content

Commit dc21ec8

Browse files
EliahKaganclaude
andcommitted
Cover submodule working trees in safe.directory on Cygwin
Add the gitdb and smmap submodule working tree paths to the safe.directory config in the Cygwin CI workflow. Without this, when GitPython opens a submodule as a Repo and runs "git cat-file --batch-check" against it, git rejects the repository for dubious ownership. The user-visible failure modes documented in the previous commit (ValueError, IndexError, AssertionError) all trace back to this rejection. The reproduce-safe-dir matrix on the previous commit produces failures for all three affected tests; this commit's CI run is expected to show those tests passing instead. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 67b2002 commit dc21ec8

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

.github/workflows/cygwin-test.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ jobs:
5959
run: |
6060
git config --global --add safe.directory "$(pwd)"
6161
git config --global --add safe.directory "$(pwd)/.git"
62+
git config --global --add safe.directory "$(pwd)/git/ext/gitdb"
63+
git config --global --add safe.directory "$(pwd)/git/ext/gitdb/gitdb/ext/smmap"
6264
git config --global core.autocrlf false
6365
6466
- &prepare-repo

0 commit comments

Comments
 (0)