Skip to content

Commit a6f494a

Browse files
EliahKaganclaude
andcommitted
Satisfy clippy 1.95's clippy::unnecessary_trailing_comma lint
Clippy 1.95 introduced a new default warning that flags trailing commas after the last argument of format-like macros. Four sites across the license tests were written with a trailing comma before the closing parenthesis — all in `assert!` and `format!` calls where there is no argument following the comma. Drop those four commas; no behaviour change. The lint was not present in the clippy 1.94 CI runner, which is why the earlier pushes didn't surface it. Surfaced now because rustup updated the toolchain locally. Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 1e9097f commit a6f494a

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

tests/licenses_variation.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -241,13 +241,13 @@ fn windows_target_includes_winapi_and_windows_family() {
241241
fn non_windows_targets_do_not_include_winapi_or_windows_family() {
242242
for platform in [LINUX_TARGET, APPLE_TARGET] {
243243
let crates = third_party_crate_names(&["max-pure"], platform);
244-
assert!(!crates.contains("winapi"), "{platform} must not include `winapi`",);
244+
assert!(!crates.contains("winapi"), "{platform} must not include `winapi`");
245245
assert!(
246246
!crates.contains("winapi-util"),
247247
"{platform} must not include `winapi-util`",
248248
);
249249
let has_windows_family = crates.iter().any(|n| n == "windows" || n.starts_with("windows-"));
250-
assert!(!has_windows_family, "{platform} must not include any `windows*` crate",);
250+
assert!(!has_windows_family, "{platform} must not include any `windows*` crate");
251251
}
252252
}
253253

@@ -273,7 +273,7 @@ fn non_apple_targets_do_not_include_security_framework() {
273273
for platform in [LINUX_TARGET, WINDOWS_TARGET] {
274274
let crates = third_party_crate_names(&["max-pure"], platform);
275275
for forbidden in ["security-framework", "security-framework-sys"] {
276-
assert!(!crates.contains(forbidden), "{platform} must not include `{forbidden}`",);
276+
assert!(!crates.contains(forbidden), "{platform} must not include `{forbidden}`");
277277
}
278278
}
279279
}

tests/licenses_workspace_attribution.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ fn every_workspace_member_with_different_attribution_is_in_manifest() {
311311
// independent of any license parser bug, so this direction admits
312312
// no excuse.
313313
if author_differs && !in_full {
314-
missing_despite_author_diff.push(format!("{name} (authors {pkg_authors:?} vs root {root_authors:?})",));
314+
missing_despite_author_diff.push(format!("{name} (authors {pkg_authors:?} vs root {root_authors:?})"));
315315
continue;
316316
}
317317

0 commit comments

Comments
 (0)