Bump Ruby version to 3.4.9. Fix lots of warning: literal string will be frozen in the future

Author: fbacall

.ruby-version

@@ -1 +1 @@
-ruby-3.3.10
+ruby-3.4.9

Dockerfile

@@ -1,4 +1,4 @@
-ARG RUBY_VERSION=3.3.10
+ARG RUBY_VERSION=3.4.9
 
 #use ruby base image
 FROM ruby:$RUBY_VERSION-slim AS base

Gemfile.lock

@@ -304,12 +304,12 @@ GEM
       activerecord
       kaminari-core (= 1.2.2)
     kaminari-core (1.2.2)
-    kt-paperclip (7.2.0)
+    kt-paperclip (7.3.0)
       activemodel (>= 4.2.0)
       activesupport (>= 4.2.0)
       marcel (~> 1.0.1)
       mime-types
-      terrapin (~> 0.6.0)
+      terrapin (>= 0.6.0, < 2.0)
     language_server-protocol (3.17.0.3)
     ld-patch (3.3.0)
       ebnf (~> 2.4)
@@ -632,7 +632,7 @@ GEM
       http-cookie (>= 1.0.2, < 2.0)
       mime-types (>= 1.16, < 4.0)
       netrc (~> 0.8)
-    reverse_markdown (2.1.1)
+    reverse_markdown (3.0.2)
       nokogiri
     rexml (3.4.4)
     rouge (4.1.3)
@@ -739,7 +739,7 @@ GEM
     sitemap-parser (0.5.6)
       nokogiri (~> 1.6)
       typhoeus (>= 0.6, < 2.0)
-    sitemap_generator (6.3.0)
+    sitemap_generator (7.0.1)
       builder (~> 3.0)
     slim (5.1.1)
       temple (~> 0.10.0)
@@ -780,8 +780,8 @@ GEM
       matrix (~> 0.4)
       rdf (~> 3.3)
     temple (0.10.4)
-    terrapin (0.6.0)
-      climate_control (>= 0.0.3, < 1.0)
+    terrapin (1.1.1)
+      climate_control
     terser (1.1.17)
       execjs (>= 0.3.0, < 3)
     thor (1.5.0)
@@ -826,7 +826,7 @@ GEM
       activesupport
       faraday (~> 2.0)
       faraday-follow_redirects
-    webmock (3.18.1)
+    webmock (3.26.2)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
@@ -837,7 +837,7 @@ GEM
     websocket-extensions (0.1.5)
     whenever (1.0.0)
       chronic (>= 0.6.3)
-    will_paginate (4.0.0)
+    will_paginate (4.0.1)
     xpath (3.2.0)
       nokogiri (~> 1.8)
     yaml-ld (0.0.3)

app/helpers/application_helper.rb

@@ -251,8 +251,8 @@ def twitter_link(username)
   end
 
   def info_button(title, opts = {}, &block)
-    classes = 'btn btn-default has-popover'
-    classes << " #{opts[:class]}" if opts[:class]
+    classes = %w(btn btn-default has-popover)
+    classes << opts[:class] if opts[:class]
     title_text = opts[:hide_text] ? '' : title
     content_tag(:a, tabindex: 0, class: classes,
                     data: { toggle: 'popover', placement: 'bottom',
@@ -300,7 +300,7 @@ def tab(text, icon, href, disabled: { check: false }, active: false, count: nil,
         options['data-tab-history-update-url'] = true
       end
 
-      text << " (#{count})" if count
+      text += " (#{count})" if count
 
       link_to("##{href}", options) do
         content_tag(:i, nil, class: icon, 'aria-hidden': 'true') + ' ' + text

app/helpers/materials_helper.rb

@@ -86,21 +86,21 @@ def display_attribute(resource, attribute, show_label: true, title: nil, markdow
     end
     string = "<p class=\"#{attribute}#{show_label ? ' no-spacing' : ''}\">"
     unless value.blank? || value.try(:strip) == 'License Not Specified'
-      string << "<strong class='text-primary'> #{title || resource.class.human_attribute_name(attribute)}: </strong>" if show_label
+      string += "<strong class='text-primary'> #{title || resource.class.human_attribute_name(attribute)}: </strong>" if show_label
       if list
-        string << '<ul>'
+        string += '<ul>'
         value.each do |v|
-          string << "<li>#{v}</li>"
+          string += "<li>#{v}</li>"
         end
-        string << '</ul>'
+        string += '</ul>'
       elsif expandable
         height_limit = expandable.is_a?(Numeric) ? expandable : nil
-        string << "<div class=\"tess-expandable\"#{" data-height-limit=\"#{height_limit}\"" if height_limit}>" + value.to_s + '</div>'
+        string += "<div class=\"tess-expandable\"#{" data-height-limit=\"#{height_limit}\"" if height_limit}>" + value.to_s + '</div>'
       else
-        string << value.to_s
+        string += value.to_s
       end
     end
-    string << '</p>'
+    string += '</p>'
     string.html_safe
   end
 

lib/ingestors/bioschemas_ingestor.rb

@@ -33,14 +33,14 @@ def read(source_url)
           output[:totals].each do |key, value|
             totals[key] += value
           end
-          no_bioschema_urls << "\n - #{url}" if !source.nil? && output[:totals].values.sum.zero?
+          no_bioschema_urls += "\n - #{url}" if !source.nil? && output[:totals].values.sum.zero?
         end
       end
 
       if totals.keys.any?
         bioschemas_summary = "Bioschemas summary:\n"
         totals.each do |type, count|
-          bioschemas_summary << "\n - #{type}: #{count}"
+          bioschemas_summary += "\n - #{type}: #{count}"
         end
         @messages << bioschemas_summary
       end
@@ -115,11 +115,11 @@ def read_content(content, url: nil)
         end
         message = "#{error} occurred while reading"
         if url.present? && url != 'https://example.com'
-          message << ": #{url} "
+          message += ": #{url} "
         else
-          message << " the source"
+          message += " the source"
         end
-        message << ". #{comment}" if comment
+        message += ". #{comment}" if comment
         @messages << message
       end
 

lib/ingestors/oai_pmh_ingestor.rb

@@ -96,7 +96,7 @@ def read_oai_rdf(client)
       if totals.keys.any?
         bioschemas_summary = "Bioschemas summary:\n"
         totals.each do |type, count|
-          bioschemas_summary << "\n - #{type}: #{count}"
+          bioschemas_summary += "\n - #{type}: #{count}"
         end
         @messages << bioschemas_summary
       end

lib/scraper.rb

@@ -114,9 +114,9 @@ def scrape(source, user = get_user, index: 0)
     end
     if validate_source(source)
       log t('scraper.messages.valid_source'), 2
-      output.concat "**Provider:** #{source.content_provider.title}\n\n"
-      output.concat "<span style='url-wrap'>**URL:** #{source.url}</span>\n\n"
-      output.concat "**Method:** #{source.ingestor_title}\n\n"
+      output += "**Provider:** #{source.content_provider.title}\n\n"
+      output += "<span style='url-wrap'>**URL:** #{source.url}</span>\n\n"
+      output += "**Method:** #{source.ingestor_title}\n\n"
 
       # get ingestor
       ingestor = Ingestors::IngestorFactory.get_ingestor(source.method)
@@ -127,16 +127,16 @@ def scrape(source, user = get_user, index: 0)
       # read records
       ingestor.read(source.url)
       unless ingestor.messages.blank?
-        output.concat "\n## Reading\n\n"
-        ingestor.messages.each { |m| output.concat "#{m}\n" }
+        output += "\n## Reading\n\n"
+        ingestor.messages.each { |m| output += "#{m}\n" }
         ingestor.messages.clear
       end
 
       # write resources
       ingestor.write(user, source.content_provider, source: source)
       unless ingestor.messages.blank?
-        output.concat "\n## Writing\n\n"
-        ingestor.messages.each { |m| output.concat "#{m}\n" }
+        output += "\n## Writing\n\n"
+        ingestor.messages.each { |m| output += "#{m}\n" }
         ingestor.messages.clear
       end
 
@@ -152,13 +152,13 @@ def scrape(source, user = get_user, index: 0)
           ", rejected[#{source.resources_rejected}]", 2
     end
   rescue StandardError => e
-    output.concat "\n**Failed:** #{e.message}\n\n"
+    output += "\n**Failed:** #{e.message}\n\n"
     log "Ingestor: #{ingestor.class} failed with: #{e.message}\t#{e.backtrace[0]}", 2
   ensure
     source.finished_at = Time.now
     run_time = source.finished_at - source_start
-    output.concat "\n**Finished at:** #{source.finished_at.strftime '%H:%M on %A, %d %B %Y (UTC)'}\n"
-    output.concat "\n**Run time:** #{run_time.round(2)}s\n"
+    output += "\n**Finished at:** #{source.finished_at.strftime '%H:%M on %A, %d %B %Y (UTC)'}\n"
+    output += "\n**Run time:** #{run_time.round(2)}s\n"
     source.log = output
     begin
       # only update enabled sources