Handle jobs attempting to run on deleted resources

Without retrying over and over

Author: fbacall

app/workers/edit_suggestion_worker.rb

@@ -8,7 +8,11 @@ def perform(arg_array)
     logger.debug "ID: #{suggestible_id}"
     logger.debug "TYPE: #{suggestible_type}"
     # Run Sidekiq task to call the BioPortal annotator
-    suggestible = suggestible_type.constantize.find(suggestible_id)
+    suggestible = suggestible_type.constantize.find_by_id(suggestible_id)
+    unless suggestible
+      logger.debug "#{suggestible_type} #{suggestible_id} not found"
+      return
+    end
     logger.debug "OBJ: #{suggestible.inspect}"
 
     # Use long description if available, otherwise short.

app/workers/geocoding_worker.rb

@@ -13,10 +13,14 @@ def perform(arg_array)
     event_id, location = arg_array
     #puts "GeocodingWorker.perform(#{event_id.to_s},#{location.to_s})"
 
-    event = Event.find(event_id)
+    event = Event.find_by_id(event_id)
+    unless event
+      logger.debug "Event #{event_id} not found"
+      return
+    end
 
     Redis.exists_returns_integer = true
-    redis = Redis.new
+    redis = Redis.new(url: TeSS::Config.redis_url)
 
     if redis.exists?(location)
       event.geocoding_cache_lookup

test/workers/edit_suggestion_worker_test.rb

@@ -8,7 +8,7 @@ class EditSuggestionWorkerTest < ActiveSupport::TestCase
     mock_nominatim
   end
 
-  test 'Get suggestions for a material' do
+  test 'get suggestions for a material' do
     material = materials(:biojs)
 
     assert_nil material.edit_suggestion
@@ -27,7 +27,7 @@ class EditSuggestionWorkerTest < ActiveSupport::TestCase
     assert_includes material.edit_suggestion.scientific_topics.map(&:preferred_label), 'Molecular dynamics'
   end
 
-  test 'Get suggestions for an event' do
+  test 'get suggestions for an event' do
     event = events(:portal_event)
 
     assert_nil event.edit_suggestion
@@ -46,7 +46,7 @@ class EditSuggestionWorkerTest < ActiveSupport::TestCase
     assert_includes event.edit_suggestion.scientific_topics.map(&:preferred_label), 'Molecular dynamics'
   end
 
-  test 'Get suggestions for a workflow' do
+  test 'get suggestions for a workflow' do
     workflow = workflows(:two)
 
     assert_nil workflow.edit_suggestion
@@ -65,7 +65,7 @@ class EditSuggestionWorkerTest < ActiveSupport::TestCase
     assert_includes workflow.edit_suggestion.scientific_topics.map(&:preferred_label), 'Molecular dynamics'
   end
 
-  test "Don't get suggestions when description is blank" do
+  test "don't get suggestions when description is blank" do
     event = events(:no_description_event)
 
     assert_nil event.edit_suggestion
@@ -80,4 +80,14 @@ class EditSuggestionWorkerTest < ActiveSupport::TestCase
 
     assert_nil event.edit_suggestion
   end
+
+  test 'gracefully handle getting suggestions for material that no longer exists' do
+    Sidekiq::Testing.inline! do
+      assert_no_difference('EditSuggestion.count') do
+        assert_nothing_raised do
+          EditSuggestionWorker.perform_async([Material.maximum(:id) + 1, 'Material'])
+        end
+      end
+    end
+  end
 end

test/workers/geocoding_worker_test.rb

@@ -2,11 +2,7 @@
 require 'sidekiq/testing'
 
 class GeocodingWorkerTest < ActiveSupport::TestCase
-
-  setup do
-  end
-
-  test 'Get coordinates for an event' do
+  test 'get coordinates for an event' do
     mock_nominatim
 
     event = events(:kilburn)
@@ -22,7 +18,7 @@ class GeocodingWorkerTest < ActiveSupport::TestCase
     assert_equal 0.34290, event.longitude.to_f.round(5)
   end
 
-  test 'Get coordinates for an event from cache' do
+  test 'get coordinates for an event from cache' do
     event = events(:kilburn)
     assert_nil event.latitude
     assert_nil event.longitude
@@ -38,4 +34,12 @@ class GeocodingWorkerTest < ActiveSupport::TestCase
     assert_equal 45, event.latitude
     assert_equal 45, event.longitude
   end
+
+  test 'gracefully handle geocoding for event that no longer exists' do
+    Sidekiq::Testing.inline! do
+      assert_nothing_raised do
+        GeocodingWorker.perform_async([Event.maximum(:id) + 1, 'Somewhere'])
+      end
+    end
+  end
 end