Skip to content

Commit 1a4a415

Browse files
authored
Merge pull request #1139 from DaanVanVugt/bugfix/uu_codes
fix category codes for uu ingestor
2 parents 9cf20a7 + 7bc51cb commit 1a4a415

3 files changed

Lines changed: 1042 additions & 1852 deletions

File tree

lib/ingestors/taxila/uu_ingestor.rb

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,14 @@ def process_uu(url)
3535
# to further match those.
3636
categories = {
3737
# en
38-
4301 => 'workshops, masterclasses',
39-
4296 => 'lectures',
40-
4295 => 'training',
41-
4293 => 'congresses, symposia',
42-
2162490 => 'workshops, masterclasses', # not really sure what this should be
43-
# nl
44-
4043 => 'workshops, masterclasses',
45-
1_916_692 => 'lectures', # lezingen, debatten,
46-
1_916_689 => 'training', # cursussen, trainingen
47-
174_593 => 'congressen, symposia'
38+
5457927 => 'training',
39+
5457925 => 'congresses, symposia',
40+
5457930 => 'workshops, masterclasses', # not really sure what this should be
41+
# # nl
42+
# 4043 => 'workshops, masterclasses',
43+
# 1_916_692 => 'lectures', # lezingen, debatten,
44+
# 1_916_689 => 'training', # cursussen, trainingen
45+
# 174_593 => 'congressen, symposia'
4846
}
4947

5048
url.split('=').last.split(',').each do |category_id|

test/unit/ingestors/taxila/uu_ingestor_test.rb

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,20 +14,20 @@ class UuIngestorTest < ActiveSupport::TestCase
1414

1515
test 'can ingest events from uu' do
1616
source = @content_provider.sources.build(
17-
url: 'https://www.uu.nl/events.rss?category-containers=4293,4295,4296,4301,2162490',
17+
url: 'https://www.uu.nl/en/events.rss?category-containers=5457932,5457933,5457934',
1818
method: 'uu',
1919
enabled: true
2020
)
2121

2222
ingestor = Ingestors::Taxila::UuIngestor.new
2323

2424
# check event doesn't
25-
new_title = 'Inloopspreekuur voor alle vragen over research data en software - week 13 2023'
26-
new_url = 'https://www.uu.nl/agenda/inloopspreekuur-voor-alle-vragen-over-research-data-en-software-230327'
25+
new_title = 'Re-Inventing Policies and Institutions for Inclusive Labour Markets in Europe and Beyond'
26+
new_url = 'https://www.uu.nl/en/events/re-inventing-policies-and-institutions-for-inclusive-labour-markets-in-europe-and-beyond'
2727
refute Event.where(title: new_title, url: new_url).any?
2828

2929
# run task
30-
assert_difference 'Event.count', 57 do
30+
assert_difference 'Event.count', 48 do
3131
freeze_time(2016) do
3232
VCR.use_cassette("ingestors/uu") do
3333
ingestor.read(source.url)
@@ -36,10 +36,10 @@ class UuIngestorTest < ActiveSupport::TestCase
3636
end
3737
end
3838

39-
assert_equal 58, ingestor.events.count
39+
assert_equal 54, ingestor.events.count
4040
assert ingestor.materials.empty?
41-
assert_equal 57, ingestor.stats[:events][:added]
42-
assert_equal 1, ingestor.stats[:events][:updated]
41+
assert_equal 48, ingestor.stats[:events][:added]
42+
assert_equal 6, ingestor.stats[:events][:updated]
4343
assert_equal 0, ingestor.stats[:events][:rejected]
4444

4545
# check event does exist
@@ -51,7 +51,7 @@ class UuIngestorTest < ActiveSupport::TestCase
5151
# check other fields
5252
assert_equal 'UU', event.source
5353
assert_equal 'Amsterdam', event.timezone
54-
assert_equal Time.zone.parse('Mon, 27 Mar 2023 13:00:00.000000000 UTC +00:00'), event.start
55-
assert_equal Time.zone.parse('Mon, 27 Mar 2023 15:00:00.000000000 UTC +00:00'), event.end
54+
assert_equal Time.zone.parse('Mon, 08 Sep 2025 07:00:00.000000000 UTC +00:00'), event.start
55+
assert_equal Time.zone.parse('Tue, 09 Sep 2025 15:00:00.000000000 UTC +00:00'), event.end
5656
end
5757
end

0 commit comments

Comments
 (0)