Fix collaboration box not loading

Author: fbacall

app/controllers/collaborations_controller.rb

@@ -38,7 +38,7 @@ def get_resource
       if name.end_with?('_id')
         c = name.chomp('_id').classify.constantize rescue NameError
         if c.method_defined?(:collaborations)
-          @resource = c.method_defined?(:friendly) ? c.friendly.find(value) : c.find(value)
+          @resource = c.respond_to?(:friendly) ? c.friendly.find(value) : c.find(value)
         end
       end
     end

test/controllers/collaborations_controller_test.rb

@@ -86,6 +86,21 @@ class CollaborationsControllerTest < ActionController::TestCase
     assert_response :forbidden
   end
 
+  test "should list collaborations for resource that supports friendly ID" do
+    lp = learning_paths(:one)
+    lp.save!
+    lp.collaborators << users(:another_regular_user)
+
+    sign_in(lp.user)
+
+    get :index, params: { format: :json, learning_path_id: lp.slug }
+    assert_response :success
+    collaborations = JSON.parse(@response.body)
+
+    assert_equal 1, collaborations.length
+    assert_includes collaborations.map { |e| e['user']['id'] }, users(:another_regular_user).id
+  end
+
   test "should list collaborations for resource that does not support friendly ID" do
     lpt = learning_path_topics(:good_and_bad)
     lpt.collaborators << users(:another_regular_user)