Skip to content

Commit 4d2688c

Browse files
DaanVanVugtfbacall
authored andcommitted
skip disabled scrapers and move to bearer auth for eventbrite
1 parent 7f2c27c commit 4d2688c

3 files changed

Lines changed: 18 additions & 11 deletions

File tree

config/locales/en.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,8 @@ en:
466466
scraper:
467467
messages:
468468
status: 'Scraper.run: %{status}'
469-
processing: 'Processing source: %{source}'
469+
processing: 'Processing source %{num}: %{source}'
470+
skipped: 'Skipped source %{num}: %{source}'
470471
processed: 'Sources processed = %{processed}'
471472
invalid: 'Validation error: %{error_message}'
472473
valid_source: 'Validation passed!'

lib/ingestors/eventbrite_ingestor.rb

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def process_eventbrite(url)
3737

3838
begin
3939
# initialise next_page
40-
next_page = "#{url}/events/?status=live&token=#{@token}"
40+
next_page = "#{url}/events/?status=live"
4141

4242
while next_page
4343
# execute REST request
@@ -49,7 +49,7 @@ def process_eventbrite(url)
4949
begin
5050
if !(pagination.nil? or pagination['has_more_items'].nil? or pagination['page_number'].nil?) && (pagination['has_more_items'])
5151
page = pagination['page_number'].to_i
52-
next_page = "#{url}/events/?page=#{page + 1}&token=#{@token}"
52+
next_page = "#{url}/events/?page=#{page + 1}"
5353
end
5454
rescue Exception => e
5555
puts "format next_page failed with: #{e.message}"
@@ -163,7 +163,7 @@ def get_eventbrite_format(id)
163163

164164
def populate_eventbrite_formats
165165
# get formats from Eventbrite
166-
url = "https://www.eventbriteapi.com/v3/formats/?token=#{@token}"
166+
url = "https://www.eventbriteapi.com/v3/formats/"
167167
response = get_json_response url
168168
# process formats
169169
response['formats'].each do |format|
@@ -190,7 +190,7 @@ def get_eventbrite_venue(id)
190190

191191
def add_eventbrite_venue(id)
192192
# get from query and add to cache if found
193-
url = "https://www.eventbriteapi.com/v3/venues/#{id}/?token=#{@token}"
193+
url = "https://www.eventbriteapi.com/v3/venues/#{id}/"
194194
venue = get_json_response url
195195
@eventbrite_objects[:venues][id] = venue unless venue.nil?
196196
rescue Exception => e
@@ -214,7 +214,7 @@ def get_eventbrite_category(id)
214214
def populate_eventbrite_categories
215215
# initialise pagination
216216
has_more_items = true
217-
url = "https://www.eventbriteapi.com/v3/categories/?token=#{@token}"
217+
url = "https://www.eventbriteapi.com/v3/categories/"
218218

219219
# query until no more pages
220220
while has_more_items
@@ -238,7 +238,7 @@ def populate_eventbrite_categories
238238

239239
has_more_items = pagination['has_more_items']
240240
page_number = pagination['page_number'] + 1
241-
url = "https://www.eventbriteapi.com/v3/categories/?page=#{page_number}&token=#{token}"
241+
url = "https://www.eventbriteapi.com/v3/categories/?page=#{page_number}"
242242
end
243243
rescue Exception => e
244244
@messages << "get Eventbrite format failed with: #{e.message}"
@@ -270,7 +270,7 @@ def get_eventbrite_subcategory(id, category_id)
270270
def populate_eventbrite_subcategories(id, category)
271271
subcategories = nil
272272
begin
273-
url = "#{category['resource_uri']}?token=#{@token}"
273+
url = "#{category['resource_uri']}"
274274
response = get_json_response url
275275
# updated cached category
276276
@eventbrite_objects[:categories][id] = response
@@ -297,7 +297,7 @@ def get_eventbrite_organizer(id)
297297

298298
def populate_eventbrite_organizer(id)
299299
# get from query and add to cache if found
300-
url = "https://www.eventbriteapi.com/v3/organizers/#{id}/?token=#{@token}"
300+
url = "https://www.eventbriteapi.com/v3/organizers/#{id}/"
301301
organizer = get_json_response url
302302
# add to cache
303303
@eventbrite_objects[:organizers][id] = organizer unless organizer.nil?
@@ -309,7 +309,8 @@ def get_json_response(url, accept_params = 'application/json')
309309
response = RestClient::Request.new(method: :get,
310310
url: CGI.unescape_html(url),
311311
verify_ssl: false,
312-
headers: { accept: accept_params }).execute
312+
headers: { accept: accept_params,
313+
authorization: "Bearer #{@token}" }).execute
313314
# check response
314315
raise "invalid response code: #{response.code}" unless response.code == 200
315316

lib/scraper.rb

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,12 @@ def run
8080
output = '<ins>**Processing Ingestion Source**</ins><br />'
8181
processed += 1
8282
log '', 1
83-
log t('scraper.messages.processing', source: processed.to_s), 1
83+
if source.enabled
84+
log t('scraper.messages.processing', source: source.provider, num: processed.to_s), 1
85+
else
86+
log t('scraper.messages.skipped', source: source.provider, num: processed.to_s), 1
87+
next
88+
end
8489
if validate_source(source)
8590
log t('scraper.messages.valid_source'), 2
8691
output.concat '<br />'

0 commit comments

Comments
 (0)