Refactor Author to generic Person model with polymorphic PersonLink

Co-authored-by: fbacall <503373+fbacall@users.noreply.github.com>

Author: Copilot

app/assets/javascripts/authors.js

@@ -0,0 +1,39 @@
+var People = {
+    add: function (role) {
+        var templateId = '#person-' + role + '-template';
+        var listId = '#person-' + role + '-list';
+        var newForm = $(templateId).clone().html();
+
+        // Ensure the index of the new form is 1 greater than the current highest index, to prevent collisions
+        var index = 0;
+        $(listId + ' .person-form').each(function () {
+            var newIndex = parseInt($(this).data('index'));
+            if (newIndex > index) {
+                index = newIndex;
+            }
+        });
+
+        // Replace the placeholder index with the actual index
+        newForm = $(newForm.replace(/replace-me/g, index + 1));
+        newForm.appendTo(listId);
+
+        return false; // Stop form being submitted
+    },
+
+    // This is just cosmetic. The actual removal is done by rails,
+    //   by virtue of the hidden checkbox being checked when the label is clicked.
+    delete: function () {
+        $(this).parents('.person-form').fadeOut();
+    }
+};
+
+document.addEventListener("turbolinks:load", function() {
+
+    $('[id^="person-"]')
+        .on('click', '[id^="add-person-"]', function() {
+            var role = $(this).data('role');
+            People.add(role);
+            return false;
+        })
+        .on('change', '.delete-person-btn input.destroy-attribute', People.delete);
+});

app/assets/javascripts/people.js

@@ -175,7 +175,7 @@ def material_params
                                      { scientific_topic_names: [] }, { scientific_topic_uris: [] },
                                      { operation_names: [] }, { operation_uris: [] },
                                      { node_ids: [] }, { node_names: [] }, { fields: [] },
-                                     authors_attributes: %i[id first_name last_name orcid _destroy],
+                                     person_links_attributes: [:id, :role, :_destroy, person_attributes: %i[id first_name last_name orcid]],
                                      external_resources_attributes: %i[id url title _destroy],
                                      external_resources: %i[url title],
                                      event_ids: [], locked_fields: [])

app/controllers/materials_controller.rb

@@ -106,9 +106,10 @@ class Material < ApplicationRecord
 
   has_many :stars, as: :resource, dependent: :destroy
 
-  has_many :material_authors, dependent: :destroy
-  has_many :authors, through: :material_authors
-  accepts_nested_attributes_for :authors, allow_destroy: true, reject_if: :all_blank
+  has_many :person_links, as: :resource, dependent: :destroy
+  has_many :people, through: :person_links
+  has_many :authors, -> { where(person_links: { role: 'author' }) }, through: :person_links, source: :person
+  accepts_nested_attributes_for :person_links, allow_destroy: true, reject_if: :all_blank
 
   # Remove trailing and squeezes (:squish option) white spaces inside the string (before_validation):
   # e.g. "James     Bond  " => "James Bond"

app/models/author.rb

@@ -0,0 +1,9 @@
+class Person < ApplicationRecord
+  has_many :person_links, dependent: :destroy
+
+  validates :first_name, :last_name, presence: true
+
+  def full_name
+    "#{first_name} #{last_name}".strip
+  end
+end

app/models/material.rb

@@ -0,0 +1,7 @@
+class PersonLink < ApplicationRecord
+  belongs_to :resource, polymorphic: true
+  belongs_to :person
+  accepts_nested_attributes_for :person, reject_if: :all_blank
+
+  validates :resource, :person, :role, presence: true
+end

app/models/material_author.rb

@@ -18,5 +18,5 @@ class MaterialSerializer < ApplicationSerializer
   has_many :nodes
   has_many :collections
   has_many :events
-  has_many :authors
+  has_many :authors, serializer: PersonSerializer
 end

app/models/person.rb

@@ -1,3 +1,3 @@
-class AuthorSerializer < ApplicationSerializer
+class PersonSerializer < ApplicationSerializer
   attributes :id, :first_name, :last_name, :orcid, :full_name
 end