Fix tests to work with new Author model

Co-authored-by: fbacall <503373+fbacall@users.noreply.github.com>

Author: Copilot

test/controllers/materials_controller_test.rb

@@ -253,7 +253,7 @@ class MaterialsControllerTest < ActionController::TestCase
           date_published: test_material.date_published,
           doi: test_material.doi,
           subsets: test_material.subsets,
-          authors: test_material.authors,
+          authors_attributes: test_material.authors.map { |a| { first_name: a.first_name, last_name: a.last_name, orcid: a.orcid } },
           contributors: test_material.contributors,
           prerequisites: test_material.prerequisites,
           syllabus: test_material.syllabus,
@@ -291,7 +291,15 @@ class MaterialsControllerTest < ActionController::TestCase
     assert_equal test_material.other_types, JSON.parse(response.body)['other_types'], 'other_types not matched'
     #assert_equal test_material.events, JSON.parse(response.body)['events'], 'events not matched'
     assert_equal test_material.target_audience, JSON.parse(response.body)['target_audience'], 'target audience not matched'
-    assert_equal test_material.authors, JSON.parse(response.body)['authors'], 'authors not matched'
+    # Authors is now an array of objects with id, first_name, last_name, orcid, full_name
+    response_authors = JSON.parse(response.body)['authors']
+    assert_equal test_material.authors.size, response_authors.size, 'authors count not matched'
+    response_authors.each_with_index do |author_json, i|
+      expected_author = test_material.authors[i]
+      assert_equal expected_author.first_name, author_json['first_name'], "author #{i} first_name not matched"
+      assert_equal expected_author.last_name, author_json['last_name'], "author #{i} last_name not matched"
+      assert_equal expected_author.full_name, author_json['full_name'], "author #{i} full_name not matched"
+    end
     assert_equal test_material.contributors, JSON.parse(response.body)['contributors'], 'contributors not matched'
     assert_equal test_material.subsets, JSON.parse(response.body)['subsets'], 'subsets not matched'
     assert_equal test_material.prerequisites, JSON.parse(response.body)['prerequisites'], 'prerequisites not matched'

test/unit/ingestors/zenodo_ingestor_test.rb

@@ -48,7 +48,7 @@ class ZenodoIngestorTest < ActiveSupport::TestCase
     assert_equal 'CC-BY-4.0', material.licence, 'material licence not matched'
     assert_equal 'active', material.status, 'material status not matched'
     assert_equal 1, material.authors.size, 'material authors count not matched.'
-    assert material.authors.include?('Australian Research Data Commons')
+    assert material.authors.any? { |a| a.full_name == 'Australian Research Data Commons' }, 'author not found'
     assert_equal '10.5281/zenodo.10656276', material.doi, 'material.doi not matched.'
 
     # check material with contributors
@@ -62,7 +62,7 @@ class ZenodoIngestorTest < ActiveSupport::TestCase
 
     # check material from page 2
     material = get_zenodo_id(10052012, 'Privacy focused health data storage and access control through personal online datastores', 'Portal Provider')
-    assert material.authors.include?('Vidanage, Anushka (orcid: 0000-0002-5386-5871)'), 'material contributors[0] missing.'
+    assert material.authors.any? { |a| a.full_name == 'Vidanage, Anushka' && a.orcid == '0000-0002-5386-5871' }, 'author with ORCID not found'
   end
 
   private