Add custom authors= setter for legacy API backwards compatibility

Co-authored-by: fbacall <503373+fbacall@users.noreply.github.com>

Author: Copilot

app/models/material.rb

@@ -111,6 +111,41 @@ class Material < ApplicationRecord
   has_many :authors, -> { where(person_links: { role: 'author' }) }, through: :person_links, source: :person
   accepts_nested_attributes_for :person_links, allow_destroy: true, reject_if: :all_blank
 
+  # Custom setter for authors that accepts both strings (legacy API) and Person objects
+  def authors=(value)
+    return if value.nil?
+    
+    # Convert to array if needed
+    authors_array = Array(value).reject(&:blank?)
+    
+    # Remove existing author links
+    person_links.where(role: 'author').destroy_all
+    
+    authors_array.each do |author|
+      if author.is_a?(String)
+        # Legacy format: parse string into first_name and last_name
+        parts = author.strip.split(/\s+/, 2)
+        first_name = parts.length > 1 ? parts[0] : ''
+        last_name = parts.length > 1 ? parts[1] : parts[0]
+        
+        person = Person.find_or_create_by!(first_name: first_name, last_name: last_name)
+        person_links.build(person: person, role: 'author')
+      elsif author.is_a?(Hash)
+        # Hash format from API
+        first_name = author[:first_name] || author['first_name'] || ''
+        last_name = author[:last_name] || author['last_name'] || ''
+        orcid = author[:orcid] || author['orcid']
+        
+        person = Person.find_or_create_by!(first_name: first_name, last_name: last_name)
+        person.update!(orcid: orcid) if orcid.present?
+        person_links.build(person: person, role: 'author')
+      elsif author.is_a?(Person)
+        # Person object
+        person_links.build(person: author, role: 'author')
+      end
+    end
+  end
+
   # Remove trailing and squeezes (:squish option) white spaces inside the string (before_validation):
   # e.g. "James     Bond  " => "James Bond"
   auto_strip_attributes :title, :description, :url, squish: false

test/models/material_test.rb

@@ -169,6 +169,61 @@ class MaterialTest < ActiveSupport::TestCase
     assert_equal 1, @material.authors.size
   end
 
+  test 'should set authors from array of strings (legacy API support)' do
+    @material.authors = ['John Doe', 'Jane Smith']
+    @material.save!
+    @material.reload
+    
+    assert_equal 2, @material.authors.size
+    john = @material.authors.find { |a| a.last_name == 'Doe' }
+    assert_not_nil john
+    assert_equal 'John', john.first_name
+    assert_equal 'Doe', john.last_name
+    
+    jane = @material.authors.find { |a| a.last_name == 'Smith' }
+    assert_not_nil jane
+    assert_equal 'Jane', jane.first_name
+    assert_equal 'Smith', jane.last_name
+  end
+
+  test 'should set authors from array of hashes' do
+    @material.authors = [
+      { first_name: 'John', last_name: 'Doe', orcid: '0000-0001-1234-5678' },
+      { first_name: 'Jane', last_name: 'Smith' }
+    ]
+    @material.save!
+    @material.reload
+    
+    assert_equal 2, @material.authors.size
+    john = @material.authors.find { |a| a.last_name == 'Doe' }
+    assert_not_nil john
+    assert_equal '0000-0001-1234-5678', john.orcid
+  end
+
+  test 'should set authors from array of Person objects' do
+    person1 = Person.create!(first_name: 'Alice', last_name: 'Wonder')
+    person2 = Person.create!(first_name: 'Bob', last_name: 'Builder')
+    
+    @material.authors = [person1, person2]
+    @material.save!
+    @material.reload
+    
+    assert_equal 2, @material.authors.size
+    assert @material.authors.include?(person1)
+    assert @material.authors.include?(person2)
+  end
+
+  test 'should handle single name in legacy author string' do
+    @material.authors = ['Madonna', 'Prince']
+    @material.save!
+    @material.reload
+    
+    assert_equal 2, @material.authors.size
+    madonna = @material.authors.find { |a| a.last_name == 'Madonna' }
+    assert_not_nil madonna
+    assert_equal '', madonna.first_name
+  end
+
   test 'should delete material when content provider deleted' do
     material = @material
     content_provider = @material.content_provider