Test fix

Author: fbacall

app/models/event.rb

@@ -115,7 +115,7 @@ class Event < ApplicationRecord
   has_one :llm_interaction, inverse_of: :event, dependent: :destroy
   accepts_nested_attributes_for :llm_interaction, allow_destroy: true
   has_one :edit_suggestion, as: :suggestible, dependent: :destroy
-  has_one :link_monitor, as: :lcheck, dependent: :destroy
+  has_one :link_monitor, as: :lcheck, dependent: :destroy, inverse_of: :link_checkable
   has_many :collection_items, as: :resource
   has_many :collections, through: :collection_items
   has_many :event_materials, dependent: :destroy

app/models/link_monitor.rb

@@ -1,5 +1,5 @@
 class LinkMonitor < ApplicationRecord
-  belongs_to :link_checkable, polymorphic: true, foreign_key: :lcheck_id, foreign_type: :lcheck_type
+  belongs_to :link_checkable, polymorphic: true, foreign_key: :lcheck_id, foreign_type: :lcheck_type, inverse_of: :link_monitor
   before_create :set_initial_date
   after_commit :reindex_resource, on: :update
 

test/models/link_monitor_test.rb

@@ -122,24 +122,30 @@ class LinkMonitorTest < ActiveSupport::TestCase
   end
 
   test 'reindex after status changing' do
+    e = events(:one)
+    index = []
+    # I have to do this because `solr_enabled` is disabled when the Event class is loaded,
+    # so it does not get the `solr_index` method even after I toggle it on below,
+    # which prevents me using Minitest's `stub` to stub out `solr_index`.
+    e.define_singleton_method(:solr_index) { index << self }
     with_settings(solr_enabled: true) do
-      e = events(:one)
       lm = e.create_link_monitor
-      index = []
-      e.stub(:solr_index, -> { index << e }) do
-        assert_empty index
-        lm.fail!(404)
-        assert_includes index, e
-      end
+      lm.update_column(:fail_count, 3)
+      assert_empty index
+      lm.fail!(404)
+      assert lm.failing?
+      assert_includes index, e
     end
   end
 
   test 'do not try and reindex non-solr resource' do
     with_settings(solr_enabled: true) do
       er = external_resources(:biotools)
       lm = er.create_link_monitor
+      lm.update_column(:fail_count, 3)
       assert_nothing_raised do
         lm.fail!(404)
+        assert lm.failing?
       end
     end
   end